Ticket #8860 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Handle the case where loading same inst. data with diff number hist

Reported by: Anders Markvardsen Owned by: Arturs Bekasovs
Priority: major Milestone: Release 3.2
Component: Muon Keywords:
Cc: stephen.cottrell@… Blocked By: #8020
Blocking: Tester: Karl Palmen

Description

Steve have come across a case that we may not have tested/considered before that is loading: same instrument data in succession where the number of histogram varies.

Make muon interface handle this according to Steve's email below:

There seems to be a new problem with the grouping in the Muon Analysis interface. When loading a run with x histograms and then a run with y histograms, the group table is not updated correctly when the second run is loaded if x<>y and the interface becomes unusable. Try this with the attached files … 30604 has 192 histograms and 34997 has 96 histograms. Load 30604 and create four groups, 1: 1-48, 2: 49-96, 3: 97-144, 4: 145-192, and a two pairs (1-2) and (3-4). All works fine. Now try and load the second file and there’s an error ‘Unable to group loaded workspace’ … if the number of histograms has changed the previous grouping should be abandoned. In fact, you still end up with all the groups showing, so I’m not sure what’s going on inside at this stage (which probably explains why it seems to stop working). I got into trouble with this bug earlier today going the other way, i.e. I loaded a run with 32 detectors and then a run with 96 detectors … it carried over the grouping from the first run to the second which made the data look very strange.

Attachments

emu00030604.nxs (2.0 MB) - added by Anders Markvardsen 7 years ago.
emu00034997.nxs (1.0 MB) - added by Anders Markvardsen 7 years ago.
emu_192_grouping.xml (559 bytes) - added by Arturs Bekasovs 7 years ago.
Grouping for EMU data with 192 histograms

Change History

Changed 7 years ago by Anders Markvardsen

Changed 7 years ago by Anders Markvardsen

comment:1 Changed 7 years ago by Arturs Bekasovs

  • Component changed from Framework to Muon
  • type changed from enhancement to defect
  • Summary changed from Muon: Handle the case where loading same inst. data with diff number hist. to Handle the case where loading same inst. data with diff number hist.

comment:2 Changed 7 years ago by Arturs Bekasovs

  • Summary changed from Handle the case where loading same inst. data with diff number hist. to Handle the case where loading same inst. data with diff number hist

comment:3 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state

comment:4 Changed 7 years ago by Arturs Bekasovs

  • Blocked By 8020 added

The interface currently loads the new data to the used workspace directly. It should be much easier when I load it to a tmp workspace. I will then just compare the number of detectors of the loaded one and the current one.

comment:5 Changed 7 years ago by Arturs Bekasovs

  • Status changed from assigned to inprogress

Refs #8860. Re-load grouping if no. spectra changes.

Changeset: 92aaa279288a9a5d3c9501a4284b77085f431875

comment:6 Changed 7 years ago by Arturs Bekasovs

Tester:

Check that what Steve talks about in the description is not happening any more:

  1. Save all attached files to the disk.
  1. Launch MuonAnalysis interface.
  1. Load 30604 (with 192 histograms).
  1. Go to Grouping Options and load emu_192_grouping.xml grouping. Try to plot the group4 to make sure everything was grouped correctly.
  1. Go back to Home and try to load 34997 (with 96 histograms). It should be loaded fine and the grouping should be replaced with the one with 96 detectors. Try to plot something to make sure it was grouped correctly.
  1. Load emu0006473 from AutoTestData. It should be loaded fine, 96 detector grouping should be abandoned, 32 detector one should be loaded.
  1. Load downloaded 34997 again. 32 detector grouping should be abandoned for 96 detector one.
  1. Load MUSR00015189 from AutoTestData. MUSR grouping should loaded (check the description on the Grouping Options).

Changed 7 years ago by Arturs Bekasovs

Grouping for EMU data with 192 histograms

comment:7 Changed 7 years ago by Arturs Bekasovs

  • Status changed from inprogress to verify
  • Resolution set to fixed

Purely interface stuff, so system tests couldn't possible be broken.

comment:8 Changed 7 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:9 Changed 7 years ago by Karl Palmen

Grouping appears to behave sensibly and there are no 'Unable to group loaded workspace' errors.

comment:10 Changed 7 years ago by Arturs Bekasovs

Refs #8860. Re-load grouping if no. spectra changes.

Changeset: 6542373d6cdf6e1856363f0eb2a06c1fcdf40680

comment:11 Changed 7 years ago by Karl Palmen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8860_muon_same_inst_diff_no_spectra'

Full changeset: c6ff3b3e9efb45df34d1c657a635a069b5ae6514

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9704

Note: See TracTickets for help on using tickets.