Ticket #8864 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Indirect Transmission bug

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: minor Milestone: Release 3.1
Component: Indirect Inelastic Keywords:
Cc: spencer.howells@… Blocked By:
Blocking: Tester: Peter Parker

Description

Small bug in the IndirectTransmission algorithm. Line 64 should be: 

scatteringXSection = result[3]+result[4]

Attachments

test_trans.py​ (335 bytes) - added by Samuel Jackson 7 years ago.
Testing script

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

Refs #8864 Correct calculation bug.

Total scattering cross section should be incoherent + coherent cross sections.

Changeset: 4cf61df6da0abed235c740097d13ac8fd13c3e5a

comment:2 Changed 7 years ago by Samuel Jackson

Refs #8864 Update reference result to match.

Changeset: 318424cda079a03f0558c8f87463667c17f77e4c

Changed 7 years ago by Samuel Jackson

Testing script

comment:3 Changed 7 years ago by Samuel Jackson

Cleared this with Nick/Martyn, it's a small change but one that shouldn't affect anything else and it means that it's producing correct output from the time we first release it.

To Tester:

Check the system tests are passing, then run the python script. You should be able to see in the output workspace that the total scattering cross section is now the sum of coherent and incoherent cross sections.

Last edited 7 years ago by Samuel Jackson (previous) (diff)

comment:4 Changed 7 years ago by Samuel Jackson

  • Milestone changed from Release 3.2 to Release 3.1

comment:5 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:6 Changed 7 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

comment:7 Changed 7 years ago by Peter Parker

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8864_indirect_transmission_bug'

Full changeset: ​d17590df501912f7bd5be173b7a6d3ffe377050f

comment:8 Changed 7 years ago by Peter Parker

Merge remote-tracking branch 'origin/bugfix/8864_indirect_transmission_bug'

Full changeset: ​34b83b29ba69e77d777983ea7af21c4b3af3b9d2

comment:9 Changed 7 years ago by Peter Parker

System tests passed locally. The output of the script shows that the total scattering cross section is now the sum of the coherent and incoherent cross sections.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9708

Note: See TracTickets for help on using tickets.