Ticket #8872 (closed: wontfix)

Opened 7 years ago

Last modified 5 years ago

Crash when loading PeaksWorkspace File

Reported by: Peter Parker Owned by: Peter Parker
Priority: critical Milestone: Release 3.1
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

Load the file 'peaks_qLab.nxs' from the Training Course Data folder. Mantid crashes.

Change History

comment:1 Changed 7 years ago by Peter Parker

This is not as big an issue as I originally thought.

The problem with the file is that it contains multiple instances of a goniometer matrix that is not invertible, namely:

[[1, 0, 0],
 [0, 1, 0],
 [0, 0, 0]]

The code that produced the file has already been fixed, so future saves-to-file of PeakWorkspaces will no longer give us that problem.

This leaves us with two remaining issues:

  • Possibly modifying the code surrounding Kernel::Matrix::Invert() so that we can deal with non-conforming matrices that aren't invertible, without crashing Mantid.
Last edited 7 years ago by Peter Parker (previous) (diff)

comment:2 Changed 7 years ago by Peter Parker

  • Status changed from new to verify
  • Resolution set to wontfix

TrainingCourseData.zip now contains a working PeaksWorkspace file.

After discussing this with Nick, I'm going to set this as wontfix. This is because:

  • We haven't had any users bring this up as a problem.
  • PeaksWorskpaces have been correctly written out from Mantid since version 3.0.
  • These files are cheap to create and there likely aren't that many incompatible files still lying around.

comment:3 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:4 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to closed

That sounds fine to me. If anyone does have a real issue a ticket can be made for the next release.

comment:5 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9716

Note: See TracTickets for help on using tickets.