Catalog select all datafiles checkbox performance

[Jay Rainey]

If the number of datafiles in the datafiles information table is large, and the user checks the select all checkbox, then Mantid freezes.

This is due to calling setSelected() in selectAllDataFiles as there is an itemSelectionChanged signal bound to the table rows, which causes Mantid to hang.

To replicate this:

1. Log into the catalog.
2. Select the WISH instrument (those investigations tend to have a large number of datafiles).
3. In the investigation id field enter: 1130006.
4. Click Search.
5. Double click on the investigation the datafiles information table will be populated with 2022 datafiles.
6. Check the checkbox in the datafiles information table's header.
7. Mantid will hang.

[Jay Rainey]

Move method closer to similar methods. Refs #8875.

Changeset: ebf07aeb6b7b34e64254c76c1d8da710410a60bc

[Jay Rainey]

Change implementation to use QT model structure. Refs #8875.

• Previously, the selection of the row was calling a signal for dataFileRowSelected, which was the result of poor performance.

Changeset: ceb635b751a3e2954b0ffa2f7bce73a5fc5bcbc8

[Jay Rainey]

Previously, I was using setSelected() inside the selectAllDataFiles() SLOT, e.g., I was calling another slot from within this one, which performed additional logic on the table, and is why it was taking an incredibly long time to select all.

To test

1. Log into the catalog and open the Search interface.
2. Select the WISH instrument.
3. In the Investigation name field enter: Investigation of the low temperature, applied field magnetic order in copper-nitrate.
4. Click search. One investigation will be returned.
5. Double click on the investigation. Notice that it has 2772 datafiles.
6. Check the check-box in the header of the table and it will select all datafiles instantly.

Note: The investigation I provided is just an example. Any investigation with a large (>1.5k) number of datafiles will do for testing.

[Russell Taylor]

Seems that I can't see this investigation with the mantidtest login, only calibration runs. Seems like there was a delay (and none afterwards) with a set of 70 files, but this should really be tested on the large set so I'll put it back in the pool.

[Peter Parker]

Merge remote-tracking branch 'origin/feature/8875_select_all_cbox_performance'

Full changeset: ​281f145c5fe593f52007d57b3bf4a3265d0c3ad8

[Peter Parker]

Tested with large number of datafiles, and the checking of the boxes was instant.

[Stuart Campbell]

This ticket has been transferred to github issue ​9719