Ticket #8888 (closed: fixed)
Stitch1D Fixes
Reported by: | Owen Arnold | Owned by: | Owen Arnold |
---|---|---|---|
Priority: | blocker | Milestone: | Release 3.1 |
Component: | Reflectometry | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Martyn Gigg |
Description
Issues reported by Tim Charlton as part of Beta Testing
- Params min and max are required as well as the step. Step should be mandatory, but min and max can be calculated from input workspaces. Both workspaces are required for this calculation.
- StartOverlap and EndOverlap also need to be calculated if not provided.
Change History
comment:2 Changed 7 years ago by Owen Arnold
- Status changed from new to inprogress
refs #8888. Fix rebin param calculations.
Fix parameter input creation/selection and update unit tests.
Changeset: d9d65837d8f267543fc6df685802f3dcb0fce191
comment:3 Changed 7 years ago by Owen Arnold
refs #8888. Calculate start and end overlap automatically.
Changeset: fe204408a7c375457c0b48ebd923bc2d7944ea17
comment:4 Changed 7 years ago by Owen Arnold
refs #8888. Make fixes to Stitch1DMany.
Also update unit tests for Stitch1DMany.
Changeset: ab56fad8b749db4ba5de0ebd8cca49be94bc3474
comment:5 Changed 7 years ago by Owen Arnold
- Status changed from inprogress to verify
- Resolution set to fixed
I've performed system tests on my local build, I've also kicked-off system tests here, which should pass http://download.mantidproject.org/jenkins/view/Manually%20Run%20Tests/job/isis_systemtests_rhel6/
comment:6 Changed 7 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:7 Changed 7 years ago by Martyn Gigg
Plots match very closely within the expected level of deviation with doing the work slightly differently.
comment:8 Changed 7 years ago by Martyn Gigg
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8888_fix_stitch1d'
Full changeset: 311fdbd8ee660221074c0c7ef431f51823b35e21
Tester. It should be sufficient that the updated unit tests are passing and that the system tests are still passing.
Using the data in the systemtest repo, you should also be able to verify that the following plots are essentially identical. There will be minor, but insignificant differences. The point of this is to compare the resulting plots.