Ticket #8898 (closed: fixed)
Improve logging within catalog
| Reported by: | Jay Rainey | Owned by: | Jay Rainey |
|---|---|---|---|
| Priority: | minor | Milestone: | Release 3.2 |
| Component: | Framework | Keywords: | maintenance |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Martyn Gigg |
Description
When P2 was attempting to log in to the catalog at SNS he noted that there was no good debug logging messages put in place.
I need to go through each method and ensure useful information is logged to debug, which could help future developers identifying any issues.
Change History
comment:2 Changed 7 years ago by Jay Rainey
Improve logging consistency. Refs #8898.
Changeset: 7b6891b7c375600aaaa65c0f78d3b4d29d91df21
comment:3 Changed 7 years ago by Jay Rainey
Use ICAT error message instead of custom. Refs #8898.
Changeset: b89580454f74ee729d04688a2dea146e6b96d2a6
comment:4 Changed 7 years ago by Jay Rainey
Add class::method to logging messages. Refs #8898.
Changeset: d1f9a531a465bc22be5a2fe75dc9bdc95a54fc71
comment:5 Changed 7 years ago by Jay Rainey
- Status changed from assigned to verify
- Priority changed from major to minor
- Resolution set to fixed
The errors thrown if the user cannot login are now more intuitive and descriptive. This would have identified the problem that Peter Peterson noted when trying to log into ICAT from SNS.
To test
- Perform a code review, and ensure the changes and information logged to DEBUG is appropriate.
comment:6 Changed 7 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:7 Changed 7 years ago by Martyn Gigg
Agreed that the debug messages are now much more helpful.
comment:8 Changed 7 years ago by Martyn Gigg
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8898_better_icat_logging'
Full changeset: eb0b49f9390ef0aeb88fe9ee20bc0c0c6a483898
Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state