Ticket #89 (closed: fixed)

Opened 13 years ago

Last modified 5 years ago

binary operation output workspace problem

Reported by: Dickon Champion Owned by: Nick Draper
Priority: major Milestone: Iteration 6
Component: Keywords:
Cc: Blocked By:
Blocking: Tester:

Description

If i have two input workspace2D objects which contain data of dimension (X,Y)

the binary operation will create an output workspace2D of dimension (X-1,Y)

while the operation will fill data for the output workspace, the output is the wrong shape, and somewhere data will be lost

a unit test would have to be incorporated to test for the size of the output workspace to spot it

Change History

comment:1 Changed 13 years ago by Dickon Champion

this is an error created by the blocksize function in the call on line 145 of BinaryOperation.cpp

comment:2 Changed 13 years ago by Dickon Champion

there is an assumption being made that the x-array is the same length as the y-array data. this is not the case as it is a histogram and it is 1 value more, it is not a failure in the triple iterator. i think instead we just need a size_xarray function and maybe a size_xdata size_ydata function or something like that.....

comment:3 Changed 13 years ago by Dickon Champion

ok as discussed, there is also a failure with the way the iterator works with respect to histogram/point data, needs a discussion within the team with options to continue forward with best solution

comment:4 Changed 13 years ago by Nick Draper

  • Owner set to Nick Draper
  • Milestone changed from Iteration 5 to Iteration 6

comment:5 Changed 13 years ago by Nick Draper

  • Status changed from new to assigned

comment:6 Changed 13 years ago by Nick Draper

  • Status changed from assigned to closed
  • Resolution set to fixed

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 937

Note: See TracTickets for help on using tickets.