Ticket #8930 (closed: duplicate)

Opened 7 years ago

Last modified 5 years ago

Fix rectangular detector issues

Reported by: Nick Draper Owned by: Vickie Lynch
Priority: critical Milestone: Release 3.3
Component: Diffraction Keywords: SSC,2014,All
Cc: Blocked By:
Blocking: Tester: Federico M Pouzols

Description

Identify and remove situations where code only works for rectanguluar detectors. To cover:

  • Code
  • Documentation

Notes from estimation:

One person fixing algorithms using FindNearstNeighbours and renaming algorithms. Another IDetector that is "flat group of lpsd" would make this much easier.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Owner set to Peter Peterson

comment:2 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state

comment:3 Changed 7 years ago by Nick Draper

  • Blocked By 9052 added

comment:4 Changed 6 years ago by Nick Draper

  • Milestone changed from Release 3.2 to Backlog

Moved to Backlog at the code freeze of release 3.2

comment:5 Changed 6 years ago by Nick Draper

  • Milestone changed from Backlog to Release 3.3

comment:6 Changed 6 years ago by Peter Peterson

  • Owner changed from Peter Peterson to Vickie Lynch

comment:7 Changed 6 years ago by Nick Draper

  • Priority changed from major to critical

Move all SSC tickets to critical by default

comment:8 Changed 6 years ago by Vickie Lynch

  • Blocked By 9052 removed

comment:9 Changed 6 years ago by Vickie Lynch

  • Status changed from assigned to verify
  • Resolution set to duplicate

The tube gap problems in integrating peaks were fixed in ticket #10254 for CORELLI and WISH in a different way than what this ticket proposed.

comment:10 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:11 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to closed

Code and documentation were fixed in #10254 following a different approach (another related ticket was: #8369). Issues seem to be fixed in both WISH and CORELLI. This ticket seems to have become invalid/duplicate.

comment:12 Changed 6 years ago by Nick Draper

  • Keywords SSC,2014,All added; SSC removed

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9773

Note: See TracTickets for help on using tickets.