Ticket #8951 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Stitch1DMany doesn't work on GroupWorkspaces

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 3.1.1
Component: Reflectometry Keywords: PatchCandidate
Cc: Blocked By:
Blocking: Tester: Gesner Passos

Description (last modified by Owen Arnold) (diff)

Fix the fact that we can't process group workspaces in Stitch1DMany

Change History

comment:1 Changed 7 years ago by Owen Arnold

  • Component changed from Framework to Reflectometry

comment:2 Changed 7 years ago by Owen Arnold

This is most probably because the special treatment around groups depends on having an InputWorkspace as a proper Workspace Property, whereby the presence of Groups can be determined. In this case however, workspaces are being parses in as a string.

comment:3 Changed 7 years ago by Owen Arnold

The following invokes the error.

group1 = Load('POLREF0004699')
group2 = Load('POLREF0004699')
stitched, scale = Stitch1DMany(InputWorkspaces="%s,%s"%(group1.name(), group2.name()), Params=[1000])

comment:4 Changed 7 years ago by Owen Arnold

  • Status changed from new to inprogress

refs #8951. Params should be mandatory for algorithm.

Since this algorithm could be used for workspaces in any units. Selecting a default step-size is bad, because for say TOF workspaces, 0.1 is a very very small step.

Changeset: 0d5b2b2e4f5255ebebffd25d66b366d421bcab21

comment:5 Changed 7 years ago by Owen Arnold

refs #8951. First-pass at implementing grouping functionality.

Not fully robust yet, but does seem to be stitching groups correctly.

Changeset: be9ee4a3f3ad9e57db82039056acea6cafe7361c

comment:6 Changed 7 years ago by Owen Arnold

refs #8951. Some refactoring and input type checking.

Tests for this have also been added.

Changeset: 78098d6df968e8c97406fe02c9b215fa93bb7c28

comment:7 Changed 7 years ago by Owen Arnold

refs #8951. Refactoring, more tests, and stricter input checking.

Check workspace groups to ensure they have the same number of workspaces. Group workspace processing is independent on whether we are scaling RHS or LHS.

Changeset: fb31e745ed55fd1015b29c85561b7a31094b51dd

comment:8 Changed 7 years ago by Owen Arnold

refs #8951. Move internals to Child Algorithms.

This prevents orphaned workspaces from outliving the algorithm.

Changeset: 63c86319dad1a3b4f5c8ee471b24a5459dfdb170

comment:9 Changed 7 years ago by Owen Arnold

refs #8951. Refactor to always return the OutputWorkspace

rename the run function and always have it return the OutputWorkspace value. This saves lots of lines of code and makes it clearer.

Changeset: e7b6ba84dd867ce62d27e6388c3b0bbba44f07b6

comment:10 Changed 7 years ago by Owen Arnold

refs #8951. Remove unnecessary naming code.

Changeset: bbd2ef622127a8f61b556434290bd50d80a4029d

comment:11 Changed 7 years ago by Owen Arnold

  • Keywords PatchCandidate added

comment:12 Changed 7 years ago by Owen Arnold

Tester.

1) The script above should now work and produce a single grouped workspace as an output.

2) Updated unit tests and system tests should be passing

3) If your require further verification, I can provide a script and some data to help with this.

comment:13 Changed 7 years ago by Owen Arnold

refs #8951. Fix RHEL6 issue.

Looks like this is due to lack of language support against 2.7.

Changeset: c8a393225a7b7318d8504c134fac153767db79a3

comment:14 Changed 7 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Description modified (diff)

comment:15 Changed 7 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:16 Changed 7 years ago by Gesner Passos

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8951_stitch_groups'

Full changeset: 6b641222b8f1663a368220461459b980c5f9f80c

comment:17 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 3.2 to Release 3.1.1

Moved to patch release 3.1.1

comment:18 Changed 7 years ago by Owen Arnold

refs #8951. Params should be mandatory for algorithm.

Since this algorithm could be used for workspaces in any units. Selecting a default step-size is bad, because for say TOF workspaces, 0.1 is a very very small step.

Changeset: 8e3c57cb11200a251170095a9b57419cf93cb8a3

comment:19 Changed 7 years ago by Owen Arnold

refs #8951. First-pass at implementing grouping functionality.

Not fully robust yet, but does seem to be stitching groups correctly.

Changeset: 571171ab9a7e9d36c0d0265f7798993ed2b6f2ba

comment:20 Changed 7 years ago by Owen Arnold

refs #8951. Some refactoring and input type checking.

Tests for this have also been added.

Changeset: 7c4aa3da01a63161bdb66ab23420d4d4ecd80f6a

comment:21 Changed 7 years ago by Owen Arnold

refs #8951. Refactoring, more tests, and stricter input checking.

Check workspace groups to ensure they have the same number of workspaces. Group workspace processing is independent on whether we are scaling RHS or LHS.

Changeset: 839c5c02dfe17886b68ff2546ad3945c65ab73c0

comment:22 Changed 7 years ago by Owen Arnold

refs #8951. Move internals to Child Algorithms.

This prevents orphaned workspaces from outliving the algorithm.

Changeset: fe9ccab4861690faf01e7b54fdb0698e1f9cf00d

comment:23 Changed 7 years ago by Owen Arnold

refs #8951. Refactor to always return the OutputWorkspace

rename the run function and always have it return the OutputWorkspace value. This saves lots of lines of code and makes it clearer.

Changeset: 6f375876d69fe91cbae6765c1c5d05371b015327

comment:24 Changed 7 years ago by Owen Arnold

refs #8951. Remove unnecessary naming code.

Changeset: e4a1520c20ce7326bd5ca8a0ef651a4998f69c4e

comment:25 Changed 7 years ago by Owen Arnold

refs #8951. Fix RHEL6 issue.

Looks like this is due to lack of language support against 2.7.

Changeset: b4619bef2ba23af443cb1ca6d5af77c0a73368ec

comment:26 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9794

Note: See TracTickets for help on using tickets.