Ticket #8953 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Geometry tab not populated correctly in v3.1

Reported by: Gesner Passos Owned by: Peter Parker
Priority: major Milestone: Release 3.1.1
Component: SANS Keywords: PatchCandidate
Cc: Blocked By: #8906
Blocking: Tester:

Description (last modified by Peter Parker) (diff)

If you load data 13347 in Mantid 3.0 SANS ISIS interface and go to the Geometry tab, it populates the position for the monitors and the detectors.

If you do the same for Mantid 3.1 it does not populate the same information.

Attachments

GeometryTabMantid3.0.png​ (111.6 KB) - added by Gesner Passos 7 years ago.
Correct way of populating Geometry tab.
GeometryTabMantid3.1.png​ (111.3 KB) - added by Gesner Passos 7 years ago.
Wrong, information missing

Change History

Changed 7 years ago by Gesner Passos

Correct way of populating Geometry tab.

comment:1 Changed 7 years ago by Gesner Passos

This data is in cycle_12_1

Changed 7 years ago by Gesner Passos

Wrong, information missing

comment:2 Changed 7 years ago by Gesner Passos

This happens only when loading eventmode data, check for example 2500 (inside systemtests), and it will populate the window.

comment:3 Changed 7 years ago by Gesner Passos

  • Blocked By 8906 added

This ticket depends on the solution proposed in #8906. The problem is that in SANSRunWindow:setGeometryDetails there is a point it tries to get the monitor, if it fails it silently give up doing the job. Hence, it will depend on the solution proposed there to be able to handle this issue.

comment:4 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state

comment:5 Changed 7 years ago by Peter Parker

  • Status changed from assigned to verify
  • Resolution set to fixed

comment:6 Changed 7 years ago by Peter Parker

  • Status changed from verify to reopened
  • Resolution fixed deleted
  • Description modified (diff)

comment:7 Changed 7 years ago by Peter Parker

  • Status changed from reopened to inprogress

comment:8 Changed 7 years ago by Peter Parker

  • Description modified (diff)

comment:9 Changed 7 years ago by Peter Parker

Refs #8953 - Retrieve monitor correctly when setting geometry details.

No longer fail silently in the case of an error. Be a bit more const-correct.

Add some asserts that hopefully make sense in the context of the function.

Changeset: 2eb2c3a2b85a9ac638ed2c57ea636561948cccb9

comment:10 Changed 7 years ago by Peter Parker

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:11 Changed 7 years ago by Peter Parker

This one's for Gesner to test, please.

comment:12 Changed 7 years ago by Gesner Passos

  • Keywords PatchCandidate added

The user noticed this and requested to correct this behavior when loading event data. This issue was introduced in 3.1. Hence, this should go 'published' ASAP.

comment:13 Changed 7 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:14 Changed 7 years ago by Karl Palmen

No branch found for this ticket. I will test master.

comment:15 Changed 7 years ago by Karl Palmen

  • Status changed from verifying to verify
  • Tester Karl Palmen deleted

Branch found.

Ticket returned to pool, so Gesner can test it.

comment:16 Changed 7 years ago by Gesner Passos

  • Status changed from verify to closed

Merge remote-tracking branch 'origin/bugfix/8953_populate_geometry_tab_correctly'

Full changeset: ​27203c2a414a8b4fa1a030cbaf67a5176356dba2

comment:17 Changed 7 years ago by Gesner Passos

The code changes are clear and concise.

I've tested both SANS2D and LOQ data, new and old, grouped and simple, with events or only histogram, raw and nexus. For all of them the Geometry tab was populated accordingly.

comment:18 Changed 7 years ago by Gesner Passos

Merge remote-tracking branch 'origin/bugfix/8953_populate_geometry_tab_correctly'

Full changeset: ​4dd2c10a82c0116ad276efc0b5871660f361622e

comment:19 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 3.2 to Release 3.1.1

Moved to patch release 3.1.1

comment:20 Changed 7 years ago by Peter Parker

Refs #8953 - Retrieve monitor correctly when setting geometry details.

No longer fail silently in the case of an error. Be a bit more const-correct.

Add some asserts that hopefully make sense in the context of the function.

Changeset: daaf2b86e824fcb6f4473d9729bb231f566c541e

comment:21 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9796

Note: See TracTickets for help on using tickets.