Ticket #8970 (closed: fixed)
Do not delete tmp reduced workspaces
Reported by: | Gesner Passos | Owned by: | Gesner Passos |
---|---|---|---|
Priority: | major | Milestone: | Release 3.1.1 |
Component: | SANS | Keywords: | PatchCandidate |
Cc: | Blocked By: | ||
Blocking: | Tester: | Peter Parker |
Description
Please can we have back temporary workspaces with the sample and can contributions to the (sample-can) result, at least for the last data reduction. It is very irritating to try to generate the can component on its own, and we like to look at it often.
Change History
comment:2 Changed 7 years ago by Gesner Passos
Tester:
- open SANS Interface
- select SANS2D instrument
- load MaskSANS2DReductionGUI.txt user file
- change to batch mode
- load sans2d_reduction_gui_batch.csv
- Run 1D reduce
- Check that in the workspace widget, you will be able to see under sample_can_reduction the temporary workspaces.
comment:3 Changed 7 years ago by Gesner Passos
- Status changed from inprogress to verify
- Resolution set to fixed
comment:4 Changed 7 years ago by Peter Parker
- Status changed from verify to verifying
- Tester set to Peter Parker
comment:5 Changed 7 years ago by Peter Parker
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8970_display_partial_workspaces'
Full changeset: 1dbfa75be3dad674e35dbccf297d5b06563aaec7
comment:6 Changed 7 years ago by Peter Parker
A sample_can_reduction ws is now generated, containing the formerly temporary workspaces.
comment:8 Changed 7 years ago by Gesner Passos
- Keywords PatchCandidate added
Removing the tmp workspaces was introduced in 3.1 but was not approved by the scientits (2 users requested to get them back already). Should go 'published' ASAP.
comment:9 Changed 7 years ago by Gesner Passos
re #8970 Check ws belongs to group before inserting it
This get rids of warning message in SANS reduction due to inserting workspace to a group which already had that workspace.
Changeset: 74f11af570fc0755ce639dc7377fd694bc92df6d
comment:10 Changed 7 years ago by Gesner Passos
This last commit was meant to go to #9032.
comment:11 Changed 7 years ago by Nick Draper
- Milestone changed from Release 3.2 to Release 3.1.1
Moved to patch release 3.1.1
comment:12 Changed 7 years ago by Gesner Passos
re #8970. Keep some workspaces from the reduction
The scientits said they are interested in some of the temporary workspaces needed for the reduction.
Changeset: a2943422fb7b46657b5f725430f8fe0302c278c8
comment:13 Changed 7 years ago by Russell Taylor
The commit in comment:12 is due to cherry-picking this work over to the patch candidate branch.
comment:14 Changed 7 years ago by Gesner Passos
re #8970 Check ws belongs to group before inserting it
This get rids of warning message in SANS reduction due to inserting workspace to a group which already had that workspace.
Changeset: 537dd039c47d38463d145e12deb8b6907f2fa394
comment:15 Changed 7 years ago by Russell Taylor
And the one in comment:14 was from pulling over the #9032 fix to the patch release branch.
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9813
re #8970. Keep some workspaces from the reduction
The scientits said they are interested in some of the temporary workspaces needed for the reduction.
Changeset: e50d97561c01563ab81e4d4cdf28482bf9e31557