LoadFullprofResolution: Enable Banks property to refer to individual banks of same number

[Karl Palmen]

At present the Banks property refers to banks by the number the bank as given in the fullprof .irf file. This causes a problem, because some .irf files have a several banks labelled bank 2.

Instead the position of the bank of the file could be used, (i.e. 1 for the first bank in the file 2 for the second bank etc.), because users (at ISIS at least) ignore the bank number.

The bank number will still be put in the OutputTableWorkspace as done at present.

Documentation will need updating to reflect this change.

[Nick Draper]

Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state

[Karl Palmen]

It has been agreed to do this my making FullprofResolution ignore the bank number (in the comment) and number them in the order they occur in the file. This would lead to considerable simplification of the code.

[Karl Palmen]

Make required change and modify unit test for it re #8974

The now redundant bank sorting code remains.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: a688c16039dd8eb0e9bf5709896605f9d8b39865

[Karl Palmen]

Update wiki documentation re #8974

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: c099295b9c49c20e3e5fced9413080253d16260b

[Karl Palmen]

Remove redundant sorting of banks re #8974

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 1f016799618090f7003d9935c5b3893ea6e81c89

[Karl Palmen]

Remove redundant sentence from documentation re #8974

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: f5d19fae201353368d9c7bc4b2d6079f133dda51

[Karl Palmen]

To test, check that the unit tests now test for banks being numbered in the order they occur in the .irf file and not according to the bank number in the file.

Check that functionality of LoadFullprofResolution remains available.

Check that with an .irf file where two banks have the same number, you can select either one of these banks. If you do not have such a file, you can edit the bank numbers in a .irf file to create one.

[Wenduo Zhou]

It broke some of the application in SNS. For example, I still want to a table workspace shows that it is belonged to bank 5 while there is only 1 bank in the .irf file.

My suggestion is that you can add another input property such that LoadFullprofResolution can set up the bank ID either in the ISIS way or using the specified value in .irf file.

[Karl Palmen]

Weduo's suggestion seems to be necessary.

Having different bank numbers for OutputTableWorkspace and Workspace would not work, because a Banks property cannot then satisfy the needs of both OutputTableWorkspace and Workspace. The latter requires workspaces of the same bank ID in the file to be differentiated.

[Karl Palmen]

Add property UseBankIDsInFile default True re #8974

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 4be52ff379fed1ade0b8d3bb1ad87acb65d24428

[Karl Palmen]

Test UseBankIDsInFile in unit test re #8974

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 99f1acee57fed4ba4ca88493c359acb879dd317e

[Karl Palmen]

Work has been delayed because this required I start again on a fresh branch. Checkbuild failed because of a merger clash with the old solution on develop. The merger I since made has failed and needs debugging.

I wish I had done a checkbuild when I started the new brach to clear out the old solution from develop before starting work.

[Karl Palmen]

The automatic merger of the unit test was incorrect.

[Karl Palmen]

Merger with develop abandoned. Work suspended till develop is reset.

[Karl Palmen]

Checkbuild worked.

[Karl Palmen]

To test check that a new option (property) has been added to use the bank numbers in the file. Check that it is by default true and that the algorithm runs as before.

Set the proprety to false and check that the bank numbers are ignored and instead the banks are numbered in the order they appear in the file.

Check that this new property is documented adequately in the wiki statements.

Check that there is an aquequate unit test for this property.

[Wenduo Zhou]

Merge remote-tracking branch 'origin/feature/8974_choose_bank_numbering'

Full changeset: ​bbb73364b1bb13989501df211b7c1b75af9230fd

[Stuart Campbell]

This ticket has been transferred to github issue ​9817