Right click doesn't work in the table

[Arturs Bekasovs]

Windows-only.

To reproduce:

1. Set Custom interfaces to be floating by default.
2. Load some data in MuonAnalysis and fit it to anything.
3. Go to Results Table tab and create a table. A table window should be added.
4. Create the table with the same name and click Yes in a confirmation box. Table window should updated.
5. Try to right-click on the table to e.g. plot one of the columns. Going back to the interface and then right-clicking again fixes the problem.

I should try to come up with non-Muon case, e.g. using script window to replace table workspace.

[Arturs Bekasovs]

This happens because when being updated the table window gets activated without updating the d_active_window of the ApplicationWindow. That's why when it gets clicked on, QMdiArea doesn't throw a signal that the current window has changed, leaving the interface to be the d_active_window, which causes activeWindow(TableWindow) check in ApplicationWindow::showTableContextMenu to fail.

[Nick Draper]

Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state

[Arturs Bekasovs]

Very difficult to use on windows.

[Arturs Bekasovs]

Might worth it. I face it again and again during demos.

[Nick Draper]

Moved to patch release 3.1.1

[Arturs Bekasovs]

Refs #8984. Reset MdaArea current to NULL when select floating win.

Changeset: af818d8df15d824ecd3cedb505abf686f3755393

[Arturs Bekasovs]

Tester:

This is quite an intricate bug, so please make sure you can reproduce it on the current stable version first. Please feel free to grab me if you couldn't.

Please make sure you understand the reason behind the code change and that it is commented well enough. It's worth mentioning, that it isn't the only place where current window is set to NULL, so it shouldn't introduce any NULL-pointer problems.

Make sure the problem is not reproducible after the changes.

Play a bit more with floating/docked windows to make sure it doesn't have any other undesirable effects. Try out all the options of the Project Explorer view and Windows menu for both floating and docked windows.

[Arturs Bekasovs]

A slight improvement worth making: when docked window activated - activate it in the MdiArea as well. Otherwise we might end up with window being active in ApplicationWindow but not in MdiArea, which is misleading.

[Arturs Bekasovs]

Refs #8984. Set current win. of MdiArea to current win. of app.

Changeset: 27ef814d6f917126a5768480869df156bdb05198

[Nick Draper]

Merge remote-tracking branch 'origin/bugfix/8984_table_right_click'

Full changeset: ​26408d66f0b23babef4b6f8338d7949ef73016c4

[Stuart Campbell]

This ticket has been transferred to github issue ​9827