Ticket #898 (closed: fixed)

Opened 11 years ago

Last modified 5 years ago

Remove limitation on choice of fwhm in FindPeaks

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: major Milestone: Iteration 19
Component: Keywords:
Cc: Blocked By:
Blocking: Tester:

Description

Currently, a set of hard-coded values were lifted from the Mariscotti paper, which means you can't have a fwhm larger than that for which he calculated values. We need to implement the calculation ourselves so that any fwhm can be used.

Also, need to allow Strip/FindPeaks to operate on only a single spectrum if desired.

Change History

comment:1 Changed 11 years ago by Russell Taylor

  • Status changed from new to assigned

comment:2 Changed 11 years ago by Russell Taylor

(In [3169]) Removed upper limit on fwhm property to Find/StripPeaks. Also added an optional property to both of these algorithms to just operate on a single spectrum instead of the whole workspace. Re #898.

comment:3 Changed 11 years ago by Russell Taylor

(In [3170]) Fix warnings. Re #898.

comment:4 Changed 11 years ago by Russell Taylor

(In [3171]) Do casting properly. Re #898.

comment:5 Changed 11 years ago by Russell Taylor

  • Status changed from assigned to closed
  • Resolution set to fixed

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​1746

Note: See TracTickets for help on using tickets.