Ticket #9007 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

DataSelector commit never made it to master.

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.2
Component: GUI Keywords:
Cc: Blocked By:
Blocking: #8284, #8938 Tester: Keith Brown

Description

Commit 01ce81fdc3794f1ca4f1c4af584d3bd4fe2fd062 never made it to master in ticket #8140. Cherry pick this commit and ensure that there are no places in Mantid that need the method that got removed.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state

comment:2 Changed 7 years ago by Samuel Jackson

  • Blocking 8938 added

comment:3 Changed 7 years ago by Samuel Jackson

  • Blocking 8284 added

comment:4 Changed 7 years ago by Samuel Jackson

  • Status changed from assigned to inprogress

Refs #9007 Swap interface to use new implementation.

Changeset: 2772b1da2414efe0ce1568464c4088abe8234b86

comment:5 Changed 7 years ago by Samuel Jackson

Refs #9007 Add extra validation check on loaded file.

It is a common situation when using auto-loading that the loaded file could get deleted before being used. I've added this check to automatically take care of this, and if re-loading fails, UserInputValidator will now output an appropriate error message.

Changeset: 07d7f90ac2c3e24ca000ad2f34073d8d43bbbbc9

comment:6 Changed 7 years ago by Samuel Jackson

Refs #9007 Use a better way of flagging a file problem.

Changeset: f8efaff3d3a715f044528e00801b5777f2665f62

comment:7 Changed 7 years ago by Samuel Jackson

Refs #9007 Update interfaces to use new validation mechanism.

This also removes redundant code that wouldn't be needed after this ticket.

Changeset: 3227098e0e71bc24e4199222555907db7a1fbfc5

comment:8 Changed 7 years ago by Samuel Jackson

Refs #9007 Remove dead code.

Changeset: 6895732226722c9e666de6dbe8f3cff008a01923

comment:9 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Test:

The changes in 01ce81fdc3794f1ca4f1c4af584d3bd4fe2fd062 should now be applied in this ticket and the interfaces updated appropriately. Additionally, I've added in an extra validation check when using the auto loading feature and subsequently removed redundant validation code in the interfaces that use it.

To verify this ticket, do a code inspection and a quick run through of the Indirect interfaces affected. Be sure to check that running an interface then deleting the workspace and then running it again does not cause Mantid to crash or throw an un-handled exception.

comment:10 Changed 7 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:11 Changed 7 years ago by Jay Rainey

  • Status changed from verifying to closed
  • The change in the missing commit have been cherry-picked and are in this branch here.
  • I used the affected interfaces and all errors appeared in message boxes.
  • I manually deleted workspaces that I had loaded (or generated),
  • Changes made are sensible and all calls to checkFileLoaded have been sensibly replaced.

comment:12 Changed 7 years ago by Jay Rainey

Merge remote-tracking branch 'origin/bugfix/9007_dataselector_missed_commit'

Full changeset: c159d5b610dccf8c647e462a5234e77bcd80eee6

comment:13 Changed 7 years ago by Samuel Jackson

  • Status changed from closed to reopened
  • Resolution fixed deleted

Unfortunately this has broken resolution input to the bayes interface.

comment:14 Changed 7 years ago by Samuel Jackson

  • Status changed from reopened to inprogress

Refs #9007 Swap interface widgets to handle loading files.

Changeset: aaab5f6cdb66e895e6c15a28029335a0d5cb72ca

comment:15 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Tester

This ticket should be built on Windows in Release Mode.

Everything above comment 13 has already been tested. If you take a copy of master and attempt to run one of the Bayes interfaces you will currently get an error about it not being able to find the resolution file. The commit above will fix that error. For more info on running the Bayes interfaces see:

http://www.mantidproject.org/Indirect:Indirect_Bayes

comment:16 Changed 7 years ago by Keith Brown

  • Status changed from verify to verifying
  • Tester changed from Jay Rainey to Keith Brown

comment:17 Changed 7 years ago by Keith Brown

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9007_dataselector_commit_missed'

Full changeset: 909ab40e58e848c2d26d781d0afd9d32fd156b6a

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9850

Note: See TracTickets for help on using tickets.