Fix Units on ConvertMDHistoToMatrixWorkspace

[Owen Arnold]

The following illustrates the problem.

CreateMDWorkspace(Dimensions='2',EventType='MDEvent',Extents='-10,10,-10,10',Names='Q_lab_x,Q_lab_y',Units='A,B',OutputWorkspace='test')
FakeMDEventData(InputWorkspace='test',UniformParams='1000',PeakParams='100000,0,0,1')
# Create a line cut
line_md = BinMD(InputWorkspace='test',AxisAligned='0',BasisVector0='X,units,0.888154,0.459545',BasisVector1='Y,units,-0.459545,0.888154',Translation='-4.93562,-2.3918',OutputExtents='0,9.61632,-0.1,0.1',OutputBins='100,1')
line_2d = ConvertMDHistoToMatrixWorkspace(line_md)
plotMD(line_md)
plotSpectrum(line_2d, 0)

These plots should be equivalent, but the X-units are wrong in the line_2d cut. This is because the Convert algorithm isn't properly sourcing the coordinate transformations. The default should be that it does. An optional parameter expressing the need to preserve the existing behaviour would be desirable.

[Owen Arnold]

refs #9009. For starters - need a test suite.

No test coverage for existing functionality. This is required first.

Changeset: 665cab907fd19a8780a96fb332226c030d65473b

[Owen Arnold]

refs #9009. Add desired transformation capabilities.

Transform to original coordinates if workspace is present.

Changeset: f68997c977c9d04ed26425c725687fcc755621a6

[Owen Arnold]

refs #9009. Design and implement coord trans test.

Unit tests now contain a test which checks the coordinate transformations applied to the output MatrixWorkspace.

Changeset: 73b5742714a2d4afdfce990f3c019f14d5cd949a

[Peter Parker]

Merge remote-tracking branch 'origin/feature/9009_fix_conversion'

Full changeset: ​9ee190c6fb4aa4b9fa7e5c5ed5371b506bef849a

[Peter Parker]

The script shows that the transforms are now taken into account. Unit tests seem to cover the functionality and are passing.

[Nick Draper]

Moved to patch release 3.1.1

[Owen Arnold]

refs #9009. For starters - need a test suite.

No test coverage for existing functionality. This is required first.

Changeset: 028b22af77ad1ba09d44202c70c10182eda809a1

[Owen Arnold]

refs #9009. Add desired transformation capabilities.

Transform to original coordinates if workspace is present.

Changeset: d51c54589e78d2a31f7c38e62a2e8c7acc951e59

[Owen Arnold]

refs #9009. Design and implement coord trans test.

Unit tests now contain a test which checks the coordinate transformations applied to the output MatrixWorkspace.

Changeset: b5e5bda6f6b1904c394723eecf515e6331e8d811

[Russell Taylor]

The above 3 commits come from pulling the work in this ticket into the patch release branch.

[Stuart Campbell]

This ticket has been transferred to github issue ​9852