Ticket #9038 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Update Frequency in stead of Accumulation method Dialog

Reported by: Owen Arnold Owned by: Keith Brown
Priority: critical Milestone: Release 3.2
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

1) The dialog that pops up for live runs should allow users to enter the update frequency.

2) The control of the accumulation method should be a separate menu option. Users should not be prompted for this. Keep the current defaults.

Change History

comment:1 Changed 7 years ago by Owen Arnold

  • Milestone changed from Backlog to Release 3.2

comment:2 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

comment:3 Changed 7 years ago by Keith Brown

  • Status changed from assigned to inprogress

Refs #9038 Ui basics and live data module altered

The live data module now takes an extra parameter for the frequency, ready for when it's needed.

The new dialog has had a basic ui file created.

Changeset: 24f54fc4e19e595d89ed586ab764640b72f5e474

comment:4 Changed 7 years ago by Keith Brown

Refs #9038 Created py files

I've passed the ui through the pyuic converter and created a child module to add the functionality to.

the child is barebones at the moment but it has been created

Changeset: 6e0bbee142f3132e0cc94e59b922344f2931ec18

comment:5 Changed 7 years ago by Keith Brown

Refs #9038 Added dialog to gui

The View menu is now the Options Menu and has had the "Live Data Options" action added.

Changeset: 7fc01f760d5fa8ec24cf0827a1ecff8efcd52da8

comment:6 Changed 7 years ago by Keith Brown

Refs #9038 Values in Qsettings set by returns form dialog

The new dialog now returns values so that the interface can set them in the Qsettings.

Whent he interface is loaded it will read in the keys form the Settigns and set some defaults if they don't exist.

Changeset: b9945cb8b64b0dd3ccc87773f30bae471b20f73c

comment:7 Changed 7 years ago by Keith Brown

Refs #9038 Decreased spin box step

The double spin box's step size has been decreased from 1 to 0.5.

Changeset: 2ad71e879d828b29ff0b1c2eb1566fe0980ababa

comment:8 Changed 7 years ago by Keith Brown

refs #9038 Choose columns dialog refactored

Just refactored the choose columns dialog to use the proper multi-inheritance form.

Also renamed a couple of variables to use lower case

Changeset: 6345a8e81d35e9d6320af6d64676c0780cc6c4e8

comment:9 Changed 7 years ago by Keith Brown

  • Status changed from inprogress to verify
  • Resolution set to fixed

To tester

Follow the instructions on http://www.mantidproject.org/Testing_Next_Reflectometry_GUI to test entire dialog. Paying attention to the "First Run", "Live Data Options" and "Hiding Columns" sections

comment:10 Changed 7 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:11 Changed 7 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9038_Refl_Live_Run_Option_Dialog'

Full changeset: 07d6b0492158088d62f16b6fbe1ae0b944af305e

comment:12 Changed 7 years ago by Owen Arnold

I've let it slide this time, but I notice that you've started using Pascal case for python function argument names again. Please don't do this.

comment:13 Changed 7 years ago by Owen Arnold

Other than that. Looks fine.

comment:14 Changed 7 years ago by Keith Brown

I just had a quick hunt in this ticket's commits for Pascal case. The ones I found have seem to have been around a bit longer than just this ticket, as they were in the choose columns dialog and load_live_runs module.

I'll fix all the pascal case i can find in the next ticket.

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9881

Note: See TracTickets for help on using tickets.