Ticket #9045 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

TimeSeriesLog autocomplete error

Reported by: Owen Arnold Owned by: Martyn Gigg
Priority: blocker Milestone: Release 3.1.1
Component: Framework Keywords: PatchCandidate
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

Run this 

w=Load("CNCS_7860")
from time import gmtime, strftime,mktime
from numpy import *
tsp=kernel.FloatTimeSeriesProperty("tsp")

And you'll get this in the latest versions of Mantid 

Load successful, Duration 0.41 seconds
Traceback (most recent call last):
  File "/Applications/MantidPlot.app/Contents/MacOS/mantidplotrc.py", line 47, in _ScopeInspector_GetFunctionAttributes
    fattr = getattr(obj,att)
RuntimeError: TimeSeries properties don't have defaults

This message would probably worry users quite a lot.

Change History

comment:1 Changed 7 years ago by Martyn Gigg

  • Status changed from new to assigned
  • Owner changed from Anyone to Martyn Gigg

comment:2 Changed 7 years ago by Martyn Gigg

  • Status changed from assigned to inprogress

Have TimeSeriesProperty return an empty default rather than throwing.

This seems more reasonable as thats what really happens. Refs #9045

Changeset: dfbcbf7dd611edbe04dae65abc06945647d238d5

comment:3 Changed 7 years ago by Martyn Gigg

Catch any exceptions when populating the autocomplete info.

Refs #9045

Changeset: 98a932ca1d42d647ad19a95b04ad04423e4d53be

comment:4 Changed 7 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

Branch: bugfix/9045_error_tsp_autocomplete

Tester: Running the script given in the description should now give no Python errors in the results log.

comment:5 Changed 7 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:6 Changed 7 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9045_error_tsp_autocomplete'

Full changeset: ​289ae9686ce2d10026f16ed3bd14278aa27ad0c1

comment:7 Changed 7 years ago by Owen Arnold

Changes fix issue. Code review looks fine.

comment:8 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 3.2 to Release 3.1.1

Moved to patch release 3.1.1

comment:9 Changed 7 years ago by Martyn Gigg

Have TimeSeriesProperty return an empty default rather than throwing.

This seems more reasonable as thats what really happens. Refs #9045

Changeset: 8feccc57748d6ccaa688906dc36e5aebf2e9ffdc

comment:10 Changed 7 years ago by Martyn Gigg

Catch any exceptions when populating the autocomplete info.

Refs #9045

Changeset: 8dcdbefe7a3019a072dc8020627c7984db9bd3c8

comment:11 Changed 7 years ago by Russell Taylor

The above two commits are from the rebase of this work onto the patch release branch.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9888

Note: See TracTickets for help on using tickets.