Ticket #9068 (closed: fixed)
Fix issue with negative but over zero time range in VSI
| Reported by: | Michael Reuter | Owned by: | Michael Reuter |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.1.1 |
| Component: | GUI | Keywords: | PatchCandidate |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Owen Arnold |
Description (last modified by Michael Reuter) (diff)
Apparently a bug has been in the VSI for a while that has to do when a dataset has a time range that is negative but runs across zero. When this happens, the initial display of the data shows the first time step at zero. Subsequently clicking on the display to do something else adjusts the display to the correct starting time.
Attachments
Change History
comment:1 Changed 7 years ago by Michael Reuter
- Status changed from new to assigned
- Description modified (diff)
Changed 7 years ago by Michael Reuter
- Attachment SEQ_MDEW_NegE.nxs added
File with negative "time" that overlaps zero
comment:3 Changed 7 years ago by Michael Reuter
Refs #9068. Adding updates to time controls.
Changeset: 1c84ea57a2beb3e6d5d3161f8885eb82e3d22e62
comment:4 Changed 7 years ago by Michael Reuter
- Status changed from inprogress to verify
- Resolution set to fixed
The branch can be found here.
To test: Before making the change, load the attached file in Mantid and view in the VSI. The "time" range is [-1,1] in the file. Observe that the initial "time" is zero, but when a subsequent GUI action is performed (move or click on window) the view changes and the "time" is now the correct starting value (-1). Make the change and see that this behavior goes away. You can also try the SEQ_MDEW.nxs file which does not suffer from this issue but should work in the correct manner anyway since its "time" range is all positive.
comment:5 Changed 7 years ago by Stuart Campbell
- Status changed from verify to verifying
- Tester set to Stuart Campbell
comment:6 Changed 7 years ago by Stuart Campbell
- Status changed from verifying to verify
- Tester Stuart Campbell deleted
comment:7 Changed 7 years ago by Nick Draper
- Milestone changed from Release 3.2 to Release 3.1.1
Moved to patch release 3.1.1
comment:8 Changed 7 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:10 Changed 7 years ago by Owen Arnold
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/9068_vsi_negative_time'
Full changeset: eb14391f0ae0497e2eded9e1f98e4f2f5016ce7b
comment:11 Changed 7 years ago by Michael Reuter
Refs #9068. Adding updates to time controls.
Changeset: 71edc3e75ceb2d6ccb8199339ae68c118b257845
comment:12 Changed 7 years ago by Russell Taylor
The commit in comment:11 is the cherry-pick over to the patch release branch.
comment:13 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9911
