Ticket #9070 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

IDA: FuryFit seg fault when attempting to plot spectrum outside of range.

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.2
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Jay Rainey

Description

This was spotted while testing another ticket. The spectrum index chooser on FuryFit does't appear to have min/max bounds set. Adding a validator and setting the min/max to the range 0 - the number of histograms should suffice.

Change History

comment:1 Changed 7 years ago by Russell Taylor

  • Status changed from new to assigned

comment:2 Changed 7 years ago by Samuel Jackson

  • Status changed from assigned to inprogress

Refs #9070 Add range checking to FuryFit interface.

Changeset: 9cc5fb518d5e23a19da814087444b451af16068d

comment:3 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Tester

I added in checking to ensure the range stays within the bounds of the workspace. Check that the seg fault no longer occurs and the plot is always kept within the bounds.

comment:4 Changed 7 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:5 Changed 7 years ago by Jay Rainey

  • Status changed from verifying to closed

Using Mantid 3.1 I could not reproduce the segmentation fault. Instead, several message dialog boxes opened (the same ones several times) when I used an invalid spectrum.

These changes address the issue of several dialog boxes opening as better values are defaulted when the user inputs an erroneous spectrum number. The changes made are sensible.

comment:6 Changed 7 years ago by Jay Rainey

  • Status changed from closed to reopened
  • Resolution fixed deleted

I made a suggestion for a code improvement, but thinking about it more the way you have done it is better.

Last edited 7 years ago by Jay Rainey (previous) (diff)

comment:7 Changed 7 years ago by Samuel Jackson

  • Status changed from reopened to verify
  • Resolution set to fixed

comment:8 Changed 7 years ago by Jay Rainey

  • Status changed from verify to closed

Merge remote-tracking branch 'origin/bugfix/9070_furyfit_seq_fault'

Full changeset: ​938456e705f7d900ab951d343b810afcec0701db

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9913

Note: See TracTickets for help on using tickets.