Ticket #9072 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Fix category on PerformIndexOperations

Reported by: Russell Taylor Owned by: Nick Draper
Priority: major Milestone: Release 3.1.1
Component: Framework Keywords: PatchCandidate
Cc: Blocked By:
Blocking: #9079 Tester: Samuel Jackson

Description

Release 3.1 has gained a single member (the titular algorithm) in an "Algorithms" category. It's the first category in the list, so it's surprising this wasn't noticed. Anyway, that category should be removed.

A couple of other comments on the algorithm (that probably shouldn't be addressed in a PatchCandidate ticket):

  • I found the name gave me no sense of what the algorithm does. Is there a better name? Or is it too late anyway?
  • It's not obvious to me what this algorithm does that GroupDetectors doesn't.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 7 years ago by Nick Draper

The other aspects of this need to be spun off as a seperate ticket

comment:3 Changed 7 years ago by Nick Draper

  • Status changed from assigned to inprogress
  • Owner set to Nick Draper

comment:4 Changed 7 years ago by Nick Draper

re #9072 change algorithm category

Changeset: d9b8fb825b4fdc92055c417fee268c4b53fed006

comment:5 Changed 7 years ago by Nick Draper

  • Blocking 9079 added

comment:5 Changed 7 years ago by Nick Draper

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Blocking 9079 removed

remaining comments passed on to ticket #9079

To test: Open mantid plot and look at the categories - or test by code reivew

comment:6 Changed 7 years ago by Owen Arnold

The name could be changed. Better name suggestions welcome as I don't think it's being used in it's own right, but It is part of release 3.1. The algorithm does not require a mapping file and has a syntax that is compatible with MultiFile loading. Allows both cropping and summing. More information on allowed operations see http://www.mantidproject.org/PerformIndexOperations. Algorithm is used by CreateTransmissionWorkspace and ReflectometryReductionOne.

Last edited 7 years ago by Owen Arnold (previous) (diff)

comment:7 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to verifying
  • Tester set to Samuel Jackson

comment:8 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 3.2 to Release 3.1.1

Moved to patch release 3.1.1

comment:10 Changed 7 years ago by Nick Draper

re #9072 change algorithm category

Changeset: 7f70ef6e570db63b8c9c5194d4543a6954cb4299

comment:11 Changed 7 years ago by Samuel Jackson

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9072_change_PerformIndexOperations_category'

Full changeset: 02c3b736ee836df23be58a151df58fb17d538c63

comment:12 Changed 7 years ago by Samuel Jackson

Checked the code builds and that the algorithm has been moved in a separate category. Code changes look good too.

comment:13 Changed 7 years ago by Nick Draper

re #9072 change algorithm category

Changeset: ec039f66d861784b29fa284ddce12519dc979985

comment:14 Changed 7 years ago by Russell Taylor

The commit is comment:13 is the cherry-picked one the patch release branch.

comment:15 Changed 7 years ago by Russell Taylor

  • Blocking 9079 added

(In #9079) Comments from Owen:

The name could be changed. Better name suggestions welcome as I don't think it's being used in it's own right, but It is part of release 3.1. The algorithm does not require a mapping file and has a syntax that is compatible with MultiFile loading. Allows both cropping and summing. More information on allowed operations see http://www.mantidproject.org/PerformIndexOperations. Algorithm is used by CreateTransmissionWorkspace and ReflectometryReductionOne.

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9915

Note: See TracTickets for help on using tickets.