Ticket #9075 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

GetEiT0atSNS fails on unexpected spectra order

Reported by: Andrei Savici Owned by: Andrei Savici
Priority: critical Milestone: Release 3.1.1
Component: Direct Inelastic Keywords: Patch candidate
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description (last modified by Russell Taylor) (diff)

SEQ_47143 has the good monitors in spectra 1 and 4 - this is an example of the SNS ADARA 'phantom' monitors which occupied positions 2 & 3.

The ChangeBinOffset call is hard-coded to act on spectra 1 and 2 when it should look at the declared monitor IDs.

Replace 

wtemp=mantid.simpleapi.ChangeBinOffset(wm,t1f*16667,0,0)
wtemp=mantid.simpleapi.ChangeBinOffset(wtemp,t2f*16667,1,1)

with 

wtemp=mantid.simpleapi.ChangeBinOffset(wm,t1f*16667,sp1,sp1)
wtemp=mantid.simpleapi.ChangeBinOffset(wtemp,t2f*16667,sp2,sp2)

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 7 years ago by Andrei Savici

  • Status changed from assigned to inprogress

Shift correct spectra. Refs #9075

Changeset: a107e3d6da0b85a9add48fe516bb8aa268d10edd

comment:3 Changed 7 years ago by Andrei Savici

  • Keywords Patch candidate added
  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:4 Changed 7 years ago by Andrei Savici

To test: 

wm=LoadNexusMonitors("SEQ_47143")
print GetEiT0atSNS(wm,8)

comment:5 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:6 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

Merge remote branch 'origin/Bugfix/9075_GetEiT0atSNS'

Full changeset: ​cb2a158fd7d69f939a481c31e802d5e18121fce4

comment:7 Changed 7 years ago by Russell Taylor

  • Milestone changed from Release 3.2 to Release 3.1.1

comment:8 Changed 7 years ago by Russell Taylor

  • Description modified (diff)
  • Summary changed from GetEiT0atSNS fail on weird spectra order to GetEiT0atSNS fails on unexpected spectra order

comment:9 Changed 7 years ago by Andrei Savici

Shift correct spectra. Refs #9075

Changeset: df395434fa7551d7cfc953977522500ba2e723c7

comment:10 Changed 7 years ago by Russell Taylor

The above commit come from cherry-picking the change over to the patch candidate branch.

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9918

Note: See TracTickets for help on using tickets.