Ticket #9087 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

SaveNXSPE validator not working with default on RHEL6

Reported by: Andrei Savici Owned by: Russell Taylor
Priority: minor Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

SaveNXSPE should read incident energy from the workspace when it is available. In MantidPlot on RHEL 6 leaving the default nan or deleting everything from the box results in invalid input. Works fine on Ubuntu 13.10. It seems like a validator problem. To test, create a workspace with DGSReduction, then in MantidPlot try to run the SaveNXSPE algorithm and use the default incident energy entry (nan).

Change History

comment:1 Changed 7 years ago by Russell Taylor

  • Status changed from new to assigned
  • Priority changed from major to minor
  • Owner changed from Nick Draper to Russell Taylor
  • Milestone changed from Backlog to Release 3.2

comment:2 Changed 7 years ago by Russell Taylor

  • Status changed from assigned to inprogress

Re #9087. Use EMPTY_DBL instead of NaN for default property values.

The NaN caused trouble with validation on RHEL6.

Note that psi had a guard to not write out a value if it is 'empty'. This obviously harks back to when the default had been EMPTY_DBL in the past, but in the current implementation it will always write out something, and that something will be NaN for the default. I've preserved that behaviour.

Changeset: 3d32f54bd207913998794addd4fb74c51c5a9591

comment:3 Changed 7 years ago by Russell Taylor

Re #9087. Formatting and indentation fixed.

Not functional changes.

Changeset: a7562303a0936e96867ce1fdaef419627e610e21

comment:4 Changed 7 years ago by Russell Taylor

  • Status changed from inprogress to verify
  • Resolution set to fixed

This should be tested on RHEL6. The old behaviour would show nan in the Efixed & Psi property boxes and validation (that little red star) would fail if you left it there or tried to leave the box blank. Other platforms were OK with this. Now the box should be empty by default, and the algorithm will run without entering anything in them.

comment:5 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:6 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to closed

Merge remote branch 'origin/bugfix/9087_savenxspe_nan_propertydefault'

Full changeset: e05fa29642f29aab8005b42321b4b7284d2f7e93

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9930

Note: See TracTickets for help on using tickets.