Ticket #9126 (closed: fixed)
Add Flowchart to DetectorDiagnostic documentation
Reported by: | Karl Palmen | Owned by: | Karl Palmen |
---|---|---|---|
Priority: | major | Milestone: | Release 3.4 |
Component: | Documentation | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #9718 | Tester: | Andrei Savici |
Description
Add a flowchart to explain the properties and child algorithms of DetectorDiagnostic. Add the flowchart in the manner explained in http://www.mantidproject.org/Documenting_Workflow_Algorithms .
Simple and obvious properties may be omitted from the flowchart to keep it tidy and easy to follow.
Attachments
Change History
comment:2 Changed 7 years ago by Karl Palmen
The code for DetectorDiagnostic was found in Algorithms rather than WorkflowAlgorithms and so may not be a bona-fide workflow algorthm.
If it is, then a new folder for the flowchart XML file would need creating in the Algorithms folder.
If it is not, then this ticket may be invalid.
comment:3 Changed 7 years ago by Nick Draper
- Status changed from new to assigned
- Owner set to Michael Reuter
- Milestone changed from Release 3.3 to Release 3.2
comment:9 Changed 6 years ago by Karl Palmen
The adding of a usage example is covered by ticket #9704.
comment:10 Changed 6 years ago by Nick Draper
Moved to the backlog at the code freeze of R3.3
comment:12 Changed 6 years ago by Karl Palmen
- Milestone changed from Backlog to Release 3.4
This ticket blocks a release 3.4 ticket.
comment:14 Changed 6 years ago by Nick Draper
Michael no longer works for the SNS, could you give this a go
comment:16 Changed 5 years ago by Karl Palmen
On examining the algorithm does five tests, which have essentially identical flowcharts.
Each test is done by a child algorithm that has a test workspace as its input workspace. If its test workspace exists, the child algorithm is executed and outputs a mask workspace and a number of failures. The mask is applied to the main input workspace and the number of failures is added to a running total.
LIST OF TESTS Workspace Child Algorithm --------- --------------- DetVanCompare MedianDetectorTest DetVanCompare DetectorEfficiencyVariation SampleTotalCountsWorkspace FindDetectorsOutsideLimits SampleBackgroundWorkspace MedianDetectorTest SampleWorkspace CreatePSDBleedMask
Changed 5 years ago by Karl Palmen
- Attachment DetectorDiagnosticInputPropertiesTable.txt added
This table shows how input properties of DetectorDiagnostic are passed to child algorithms.
comment:17 Changed 5 years ago by Karl Palmen
Ticket #9704 for the usage example is still not complete.
comment:18 Changed 5 years ago by Karl Palmen
Add first draft of DOT file for flowchart re #9126
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: ad8ad5fff2e7984bf24c66fa7522196151c2441f
comment:19 Changed 5 years ago by Karl Palmen
Further work on document and flowchart re #9126
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 17e33b9ec43593c660d400c8687c8ade41c6175c
comment:20 Changed 5 years ago by Karl Palmen
Rename DOT file re #9126
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: e4079a3fdf1d99e70ee6d16c3957b1d9b542e46b
comment:21 Changed 5 years ago by Karl Palmen
Correct the flowchart re #9126
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 8fb4c6819de2a2feeab88f7cee76280bf03cbfe8
comment:22 Changed 5 years ago by Karl Palmen
Modify document re #9126
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 3e2eb83761b4ebe1f5138d7530b4805dfb85efcd
comment:23 Changed 5 years ago by Karl Palmen
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #633.
comment:24 Changed 5 years ago by Karl Palmen
This is now affected by the issue of https://github.com/mantidproject/mantid/pull/638
comment:25 Changed 5 years ago by Andrei Savici
- Status changed from verify to verifying
- Tester set to Andrei Savici
comment:26 Changed 5 years ago by Andrei Savici
- Status changed from verifying to closed
Merge pull request #633 from mantidproject/feature/9126_detector_diagnostic
New Flowchart for DetectorDiagnostic workflow algorithm
Full changeset: 306679785ac355d5796b260d95d0bfe76f00b5bb
comment:27 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9969