Ticket #9135 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

ISIS iliad does not work with monitors separated from data

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Release 3.2
Component: Direct Inelastic Keywords:
Cc: Blocked By: #9312
Blocking: Tester: Anders Markvardsen

Description (last modified by Alex Buts) (diff)

If users loads raw data and separate monitors from the main workspace, the monitor workspace ISIS iliad fails as it can not find separate monitor workspace.

Change History

comment:1 Changed 7 years ago by Alex Buts

refs #9135 This should fix the issue

Changeset: 0801adae2006344d9f571eac0626d03893c333f2

comment:2 Changed 7 years ago by Alex Buts

  • Component changed from Framework to Direct Inelastic

comment:3 Changed 7 years ago by Alex Buts

refs #9135 export function which find spectrum ID from Sp Number

Changeset: 9d720614d25ac78e017368653dea25225299e999

comment:4 Changed 7 years ago by Alex Buts

refs #9135 Work with monitors loaded separately.

Changeset: 7e891fdb8984a56ba447e28fd652e610e59d5a5a

comment:5 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned
  • Summary changed from ISIS iliad does not work in some usages scenarios to ISIS iliad does not work with monitors separate from data on linux

comment:6 Changed 7 years ago by Alex Buts

  • Status changed from assigned to inprogress

refs #9135 Careful treatment of monitor spectra

Not if it caused any problem, but explicitly executed the operation to find proper monitor number corresponding to monitor ID

Changeset: d023298389f953b44535fc6a487450221f27f681

comment:7 Changed 7 years ago by Alex Buts

refs #9135 make LET functions more or less generic

Changeset: e29b4922c0d788b20b144e16da9402dcbdf3b4ce

comment:8 Changed 7 years ago by Alex Buts

refs #9135 LoadRaw loads separateMonitors in low case _monitors wksps

Changeset: 4cd3a86a3a030ea0782d8b86234651bfbae1cce0

comment:9 Changed 7 years ago by Alex Buts

refs #9135 fixed unit test for different case monitors ws

Changeset: 11334d84dbb370e8ee8df490da788e3328e9048c

comment:10 Changed 7 years ago by Alex Buts

refs #9135 Moved monitors in separate workspace together with data WS

Changeset: 3293b2f510697774cd8fb0fc720045b21e4afcee

comment:11 Changed 7 years ago by Alex Buts

refs #9135 Modified LoadRaw to produce low case monitor workspace name

when monitors are loaded separately from the main workspace

Changeset: fc9b6c66562e7480f4a2c319e2ed90e62a7c38b5

comment:12 Changed 7 years ago by Alex Buts

  • Blocked By 9312 added

comment:13 Changed 7 years ago by Alex Buts

refs #9135 Remove background skips monitors

Changeset: d8f4c3893446e542b02f6eedddfdffb698fbce92

comment:14 Changed 6 years ago by Alex Buts

refs #9135 Changed Test ISIS functions to latest qtiGenie version

Changeset: 95341e1425a003f8e94ffa18a8f55310acd2cd9b

comment:15 Changed 6 years ago by Alex Buts

refs #9135 Changed default load option for raw files to include

as hard masks (msk) for MARI become invalid otherwise

Changeset: bbc788592914dfc8c36f99f9a58174d1e1861859

comment:16 Changed 6 years ago by Alex Buts

refs #9135 fixing test for separate monitors load name

as this is what have changed.

Changeset: a0875f1f511c49d761442941528eedc40911b862

comment:17 Changed 6 years ago by Alex Buts

refs #9135 trivial Comments

Changeset: e2ef4a5406cb13980ae613258683c7ce5bf89502

comment:18 Changed 6 years ago by Alex Buts

refs #9135 Modified ISIS reduction to load monitors separately

except special cases (MARI). new parameter in reduction is responsible for this.

Changeset: 9622a0d671a3ac1bb915b26f04a7ff552cff6730

comment:19 Changed 6 years ago by Alex Buts

refs #9135 Maps sample has been modified

to work with separate monitors. It has been proven that error in reduction is caused by round-off error (eps<10-7) and then multiplying such workspace by 1010.

Changeset: 3c9f5186d06a415dca3cb77ba2608a693dd0bc80

comment:20 Changed 6 years ago by Alex Buts

refs #9135 fixing system test which still has low case monitors ws

in it.

Changeset: f0e2c005c7403d52904a75961d1096b6f67b5077

comment:21 Changed 6 years ago by Alex Buts

Can be tested only after #9312. Changes are both in Mantid and SystemTests repository.

Here I have trivial but numerous changes in ISIS reduction, which allow load monitors separately from workspaces and partially unify reduction interface for raw histogram and nexus files. There are also cases where this approach creates problem - this special case is separated and described in IDF.

Changes are relatively simple and verified by system tests to be correct so no much to test here.

Last edited 6 years ago by Alex Buts (previous) (diff)

comment:22 Changed 6 years ago by Alex Buts

  • Blocked By 9312 removed

comment:22 Changed 6 years ago by Alex Buts

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Description modified (diff)
  • Blocked By 9312 added
  • Summary changed from ISIS iliad does not work with monitors separate from data on linux to ISIS iliad does not work with monitors separated from data

comment:23 Changed 6 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:25 Changed 6 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9135_ISISRawAndMonitors'

Full changeset: ​3587373709f2860b7b55c5c0bec48129243d9809

comment:26 Changed 6 years ago by Anders Markvardsen

Merge remote-tracking branch 'origin/bugfix/9135_ISISRawAndMonitors'

Full changeset: ​28c03aa327c7f449f15d2ca8182779a0ffd6d8a2

comment:27 Changed 6 years ago by Anders Markvardsen

verified changes to system tests pass

comment:28 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9978

Note: See TracTickets for help on using tickets.