Ticket #9152 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Misleading Error message in RebinParamsValidator

Reported by: Keith Brown Owned by: Keith Brown
Priority: trivial Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description

While i was testing #8849 i got confused by one of the error messages that was generated.

Before testing I'd never used rebin before so didn't know what it required in a string list. I put in an even number of values and it failed. I now know that it takes in an odd number of parameters, but the error message that was generated when I gave it two parameters confused me as at the time as I was giving it an even number of parameters:

"The number of bin boundaries must be even"

Consider making this error message more helpful or understandable

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner changed from Anyone to Keith Brown

comment:2 Changed 7 years ago by Keith Brown

  • Status changed from assigned to inprogress

Refs #9152 Error message less misleading

Even though before the error was okay, it wasn't clear to someone who didn't know about rebinning, nor was it always correct like in the case of "first boundary, width, last boundary, width, last boundary" as there are an odd number of boundary values.

The error now states that the number of parameters must be odd as this is what it checks for in the validator, and would mean that the correct number of boundaries is present.

Changeset: 235945d882b2ea60227b8a429181c84866e883a6

comment:3 Changed 7 years ago by Keith Brown

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Tester:

Try re-binning, supplying an even number of parameters, the updated error should appear.

comment:4 Changed 7 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:5 Changed 7 years ago by Vickie Lynch

  • Milestone changed from Backlog to Release 3.2

comment:6 Changed 7 years ago by Vickie Lynch

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/9152_RebinParamsValidator_Error_message'

Full changeset: c10d989e0e68822df1f97b2871c9c64960e5ccc8

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9995

Note: See TracTickets for help on using tickets.