Ticket #9157 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

New system test for algorithm coding conventions

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description (last modified by Peter Peterson) (diff)

Mantid Standards declares some coding conventions for algorithm (and fit function) names and the names of their parameters. Write a system test that verifies algorithms and fit functions follow them.

Change History

comment:1 Changed 7 years ago by Peter Peterson

  • Status changed from new to assigned

comment:2 Changed 7 years ago by Peter Peterson

  • Description modified (diff)

comment:3 Changed 7 years ago by Peter Peterson

This is taking over the work of #9158 as well.

comment:4 Changed 7 years ago by Peter Peterson

  • Status changed from assigned to inprogress

Re #9157. First, permissive, version of coding convention check

Changeset: 71d8ccad41e429c61f09720ee5692aaab6653ba6

comment:5 Changed 7 years ago by Peter Peterson

Re #9157. Renaming system test.

Changeset: 739f67cd4af3be996c82a1b2fd28180f0b58b038

comment:6 Changed 7 years ago by Peter Peterson

Re #9157. Adding test for fit function coding conventions.

Changeset: 2fff979e8f81b6fdf67c700ce42ba80ee7235c09

comment:7 Changed 7 years ago by Peter Peterson

Re #9157. Added checks for categories.

Changeset: 9c221d82bfebdd4aaa2e5ff426b3f8ee1d04043d

comment:8 Changed 7 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is at systemtests:​feature/9157_naming_conventions.

To test: See that the nightly build isn't broken and look at what is actually being tested.

comment:9 Changed 7 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:10 Changed 7 years ago by Vickie Lynch

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/9157_naming_conventions'

Full changeset: ​6ca1fdc36dd195c0c65dfe4af9f809a4b46cc708

comment:11 Changed 7 years ago by Peter Peterson

Re #9157. First, permissive, version of coding convention check

Changeset: 569c810bcb43e3e64c19e8b9bf5b70f858131339

comment:12 Changed 7 years ago by Peter Peterson

Re #9157. Renaming system test.

Changeset: 5e12fc14f2f9aa50b143bf93ba90fe0f3b90513b

comment:13 Changed 7 years ago by Peter Peterson

Re #9157. Adding test for fit function coding conventions.

Changeset: 1f17dc2ecfc05c2895cc2a668d7f293b4a33e745

comment:14 Changed 7 years ago by Peter Peterson

Re #9157. Added checks for categories.

Changeset: c0c122ae05022726b8135bb0ef6575a17a2cbbac

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10000

Note: See TracTickets for help on using tickets.