Ticket #9174 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Add option to output additional info in PlotPeakByLogValue

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.2
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

#6622 added the ability to get the workspaces output from fit when using PlotPeakByLogValue. It would also be useful to pass the OutputCompositeMembers and ConvolveMembers options to Fit as well.

Attachments

test_plot_peak.py​ (718 bytes) - added by Samuel Jackson 7 years ago.
Testing script

Change History

comment:1 Changed 7 years ago by Owen Arnold

  • Status changed from new to assigned

Sounds reasonable. Make sure you add full test instructions.

comment:2 Changed 7 years ago by Samuel Jackson

  • Status changed from assigned to inprogress

Refs #9174 Add additional options to PlotPeakByLogValue.

Changeset: 06d26552aacd8b61755242fe1a044b5a8f17df45

comment:3 Changed 7 years ago by Samuel Jackson

Refs #9174 Add unit test for new options.

Changeset: b6d19f39658ad3aba44309d9898a850b8cb7df28

comment:4 Changed 7 years ago by Samuel Jackson

Refs #9174 Add additional options to Fitting Dialog.

Changeset: d66604ef1e92e50f6e35933bad2a51bad67fbed2

comment:5 Changed 7 years ago by Samuel Jackson

To Test:

I've added a couple of additional options to PlotPeakByLogValue, which allows us to get extra information about the fitting out for each spectrum. To test this you will need to:

  • Check the unit and system tests are passing.
  • Run PlotPeakByLogValue with a composite function with the additional options set to true.
    • I've added a test script with an example.
    • Check that the fit *_Workspace has 2 additional spectra called "LinearBackground" and "Convolution"
  • Check that the new options available on the Sequential Fit dialog provide the same functionality as above, but through the GUI.
Last edited 7 years ago by Samuel Jackson (previous) (diff)

Changed 7 years ago by Samuel Jackson

Testing script

comment:6 Changed 7 years ago by Samuel Jackson

  • Blocking 8739 added

comment:6 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Blocking 8739 removed

comment:7 Changed 7 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:9 Changed 7 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9174_plotpeak_additional_output'

Full changeset: ​78bff9c6a0fcb131888421b82282a7c4576c3c43

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10017

Note: See TracTickets for help on using tickets.