Ticket #9197 (closed: fixed)
Load ILL Add Vanadium workspace for elastic peak finding
| Reported by: | Ricardo Leal | Owned by: | Ricardo Leal |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.2 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Samuel Jackson |
Description
Besides the optional vanadium file (See Ticket #8526), an optional workspace with the same aim is added.
Change History
comment:3 Changed 7 years ago by Ricardo Ferraz Leal
- Status changed from assigned to inprogress
Added optional vana workspace Re #9197
Changeset: c28334baba29da3ef5d7298a733c865e23e8b96a
comment:4 Changed 7 years ago by Ricardo Ferraz Leal
Added documentation Re #9197
Changeset: 80cc8f6aa0f25a9025571bf4dd652bb80fa0eb7f
comment:5 Changed 7 years ago by Ricardo Ferraz Leal
Added test for the vanadium workspace Re #9197
Changeset: 793752b136a45d2ea412642111579e3046803877
comment:6 Changed 7 years ago by Ricardo Leal
To test:
Algorithm: LoadILL (Just load should also work).
There are 2 files in the systemtests repository (Data Folder):
Data/ILLIN5_Sample_096003.nxs Data/ILLIN5_Vana_095893.nxs
Loading the ILLIN5_Sample_096003.nxs and ConvertUnits to DeltaE the Elastic Peak is not aligned as the dispersion peak is stronger than the elastic and the Elastic Peak Finder routine fails.
To test:
- Load Data/ILLIN5_Vana_095893.nxs. Name the output workspace as Vana.
- Load Data/ILLIN5_Sample_096003.nxs as the sample and Vana (step 1) as VanadiumWorkspace.
- On the output of 2. run ConvertUnits to DeltaE. Now the Elastic Peak should be alligned at E=0. Note the elastic peak is weaker than the dispersion peak.
There is also a system test for testing this:
SystemTests/AnalysisTests/LoadILLIN5Test.py
comment:7 Changed 7 years ago by Ricardo Leal
- Status changed from inprogress to verify
- Resolution set to fixed
comment:8 Changed 7 years ago by Samuel Jackson
- Status changed from verify to verifying
- Tester set to Samuel Jackson
comment:9 Changed 7 years ago by Samuel Jackson
- Status changed from verifying to reopened
- Resolution fixed deleted
It doesn't look like this has been merged into develop. Might be because it was thrown off during the reset earlier in the week?
comment:10 Changed 7 years ago by Ricardo Leal
- Status changed from reopened to verify
- Resolution set to fixed
My fault. Forgot to verify before leaving for holidays. Just merged it into develop. Feel free to test it again. Thanks.
comment:12 Changed 6 years ago by Samuel Jackson
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/9197_LoadILL_Vana_optional_ws'
Full changeset: 3097d08099f595404a791b386ceb7edcc653aede
comment:13 Changed 6 years ago by Martyn Gigg
Merge remote-tracking branch 'origin/feature/9197_LoadILL_Vana_optional_ws'
Conflicts:
SystemTests/AnalysisTests/ILLIN5Test.py
Full changeset: 63b3ca5a86218721f531c9d3a0dae0bcdd7ed995
comment:14 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10040
