Ticket #9201 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

MERLIN IDF changes

Reported by: Alex Buts Owned by: Alex Buts
Priority: trivial Milestone: Release 3.2
Component: Direct Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Samuel Jackson

Description

Merlin vanadium mass have changed. IS-s want these changes in Mantid and also to see vanadium mass printed when reduction runs (to be sure all stuff works fine)

Change History

comment:1 Changed 7 years ago by Martyn Gigg

  • Status changed from new to assigned

comment:2 Changed 7 years ago by Alex Buts

  • Status changed from assigned to inprogress

refs #9201 dgreduce reports default vanadium mass.

Changeset: 0b3e0e3d4477733106171b76230bd05139458de2

comment:3 Changed 7 years ago by Alex Buts

refs #9201 modified MERLIN_Definition validity range

and fresh definitions have been added

Changeset: 779d09a62eb52f7762055d5acc428199a7e6cd75

comment:4 Changed 7 years ago by Alex Buts

  • Status changed from inprogress to verify
  • Resolution set to fixed

Trivial requests and trivial solution. As soon as system tests pass, one can safely consider this ticket resolved.

comment:5 Changed 7 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:6 Changed 7 years ago by Anders Markvardsen

  • Status changed from verifying to reopened
  • Resolution fixed deleted

When during git test start 9201 I got the message:

ERROR: Branch 'feature/9201_MerlinIDF' has not been fully merged to develop, meaning it is not possible to know whether the code is valid on all environments .

Contact Alex Buts on Alex.Buts@… (or via skype) and ask them to merge t he code to develop using 'git checkbuild' from their branch feature/9201_MerlinIDF and l et you know when it passes testing on the buildservers so you can start testing.

comment:7 Changed 7 years ago by Alex Buts

  • Status changed from reopened to verify
  • Resolution set to fixed

Brunch was not merged to develop at all.

This is what happens when people reset develop and do not advertise their changes. Has to be some automated way of finding out these situations.

comment:8 Changed 7 years ago by Anders Markvardsen

  • Status changed from verify to verifying

comment:9 Changed 7 years ago by Anders Markvardsen

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Still receiving this message when git test start 9201

ERROR: Branch 'feature/9201_MerlinIDF' has not been fully merged to develop, meaning it is not possible to know whether the code is valid on all environments .

Contact Alex Buts on Alex.Buts@… (or via skype) and ask them to merge t he code to develop using 'git checkbuild' from their branch feature/9201_MerlinIDF and l et you know when it passes testing on the buildservers so you can start testing.

comment:10 Changed 7 years ago by Alex Buts

  • Status changed from reopened to verify
  • Resolution set to fixed

this is because ticket is sitting in develop for too long and people reset develop not telling to anybody

comment:11 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to verifying
  • Tester changed from Anders Markvardsen to Samuel Jackson

comment:12 Changed 7 years ago by Samuel Jackson

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9201_MerlinIDF'

Full changeset: ​bb946a24123ad1da393266e6a91138a7a10d4f40

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10044

Note: See TracTickets for help on using tickets.