Ticket #9221 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Use setMatrixWorkspace for setting workspace index to compton profile functions.

Reported by: Roman Tolchenov Owned by: Roman Tolchenov
Priority: major Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Jay Rainey

Description

Refactor functions related to ComptonProfile and ComptonScateringCountRate to use IFunction::setMatrixWorkspace method for setting the workspace index.

Attachments

fit1.py​ (1.2 KB) - added by Roman Tolchenov 6 years ago.

Change History

comment:1 Changed 7 years ago by Roman Tolchenov

Re #9221. A doxygen comment fix

Changeset: 485f8df3d1428badf4a9880ba2fa21c9e14c5a66

comment:2 Changed 7 years ago by Roman Tolchenov

Re #9221. Corrected system tests

Changeset: 83396281dc1779aaab1c9d54b36d2450de5bcdd4

comment:3 Changed 7 years ago by Roman Tolchenov

Re #9221. Fix the compiler warnings.

Changeset: 2fda0108d7cee5cfaeda38915afc0f870baae34c

comment:4 Changed 7 years ago by Martyn Gigg

  • Status changed from new to assigned

comment:5 Changed 6 years ago by Russell Taylor

There's still a doxygen warning after the change in comment:1 - the parameter called "wi" has been referred to as "wsIndex" in the doxygen documentation.

comment:6 Changed 6 years ago by Martyn Gigg

  • Status changed from assigned to inprogress

Fix doxygen warning in setMatrixWorkspace method.

Refs #9221

Changeset: 9fe9e8b867438dbeb21eb0326af4c57c7a395d05

Changed 6 years ago by Roman Tolchenov

comment:7 Changed 6 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

To tester:

Run the attached script. The result workspaces must show good fits of the bigger peak.

comment:8 Changed 6 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:9 Changed 6 years ago by Jay Rainey

  • Status changed from verifying to closed

The related classes have been re-factored and now make use of IFunction::setMatrixWorkspace. The output of the script suggested in comment:7 was as expected. The build servers are passing (these changes have been there for ages). Closing.

comment:10 Changed 6 years ago by Jay Rainey

Merge remote-tracking branch 'origin/feature/9221_comptonprofile_setmatrixworkspace'

Full changeset: ​ebf714874283dffacd77c6141025cdcdb8d41e8d

comment:11 Changed 6 years ago by Jay Rainey

Merge remote-tracking branch 'origin/feature/9221_comptonprofile_setmatrixworkspace'

Full changeset: ​4e44b2f98a46dfa810ab232782f8e93fcdf72e45

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10064

Note: See TracTickets for help on using tickets.