Possible issues with MDGeometry destructor

[Owen Arnold]

Need to investigate why the MDGeometry destructor needs to do anything with the ADS, and remove this requirement if possible. Destructor currently looks like this:

  MDGeometry::~MDGeometry()
  {
    for (size_t i=0; i<m_transforms_FromOriginal.size(); i++)
      delete m_transforms_FromOriginal[i];
    for (size_t i=0; i<m_transforms_ToOriginal.size(); i++)
      delete m_transforms_ToOriginal[i];
    if (m_observingDelete)
    {
      // Stop watching once object is deleted
      API::AnalysisDataService::Instance().notificationCenter.removeObserver(m_delete_observer);
    }
    m_dimensions.clear();
  }

[Stuart Campbell]

This ticket has been transferred to github issue ​10076