Ticket #9245 (closed: fixed)
SaveCanSAS1Dv.2 has wrong unit for Lambda tag
Reported by: | Martyn Gigg | Owned by: | Peter Parker |
---|---|---|---|
Priority: | major | Milestone: | Release 3.2 |
Component: | SANS | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Karl Palmen |
Description
SaveCanSAS1Dv.2 is writing files with transmission data containing
<Lambda unit="Wavelength">
Wavelength here should, of course, be replaced by Angstroms!!!
This is actually causing a third-party application to fall over.
Steve King, ISIS
Change History
comment:2 Changed 6 years ago by Peter Parker
Unit rules for the CanSAS format:
http://www.cansas.org/formats/canSAS1d/1.1/doc/overview.html#rules
comment:3 Changed 6 years ago by Peter Parker
- Status changed from assigned to inprogress
Refs #9245 - Output correct unit string in CanSAS format.
Also, the CanSAS format expects "A" rather than "Angstrom".
Changeset: 3a32cf1fb48194b225f90e01919b45c75048b9c0
comment:4 Changed 6 years ago by Peter Parker
- Status changed from inprogress to verify
- Resolution set to fixed
To Test:
A code review should be all that's needed here -- the unit tests have been updated to reflect the change.
Make sure all tests are passing.
comment:5 Changed 6 years ago by Karl Palmen
- Status changed from verify to verifying
- Tester set to Karl Palmen
comment:6 Changed 6 years ago by Karl Palmen
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bigfix/9245_savecansas1d_has_wrong_unit_for_lambda_tag'
Full changeset: 6c0c143c1683e5ac205ec500aa879efaf7f0aed9