Ticket #9247 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Fix Coverity issues in VATES code.

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: major Milestone: Release 3.2
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

Go through the Coverity issues for the VATES code. Time boxed to two hours.

Change History

comment:1 Changed 7 years ago by Michael Reuter

  • Status changed from new to assigned

comment:2 Changed 7 years ago by Michael Reuter

  • Status changed from assigned to inprogress

comment:3 Changed 7 years ago by Michael Reuter

Refs #9247. Fixing unchecked return on iterator.

Changeset: beabf6ab19e693f5bfaa239d34f3386f706a53f6

comment:4 Changed 7 years ago by Michael Reuter

Refs #9247. Fixing unchecked dynamic cast.

Changeset: 6526b97acb19bdf5af27d6f2d847d784bc49bc9f

comment:5 Changed 7 years ago by Michael Reuter

Refs #9247. Fixing some uninitialized members.

Changeset: 5ffad5c482256b84c9d8c996419db76ef8f3febd

comment:6 Changed 7 years ago by Michael Reuter

Refs #9247. Making RHEL6 happy.

Having to lobotomize C++11 code since RHEL6 can't cope. I hate RHEL6.

Changeset: 5663c9d6a845bffc8402eb4d652f20547784e1ec

comment:7 Changed 6 years ago by Michael Reuter

  • Status changed from inprogress to verify
  • Resolution set to fixed

The branch can be found ​here.

To test: All the VateAPI unti tests should still work. One can do quick functionality tests with the VSI. The best thing to do is look at coverity, but I've never been able to figure out how to determine what's fixed.

comment:8 Changed 6 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:9 Changed 6 years ago by Russell Taylor

  • Status changed from verifying to closed

Merge remote branch 'origin/bugfix/9247_vates_coverity_issues'

Full changeset: ​099ed882ca11033af6ee3c97b726c267a9a8b2cc

comment:10 Changed 6 years ago by Russell Taylor

Looks OK from inspection. As the coverity job runs on master it's unfortunately not possible to see from there whether an issue has been fixed before the ticket is closed and merged.

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10090

Note: See TracTickets for help on using tickets.