Ticket #9311 (closed: fixed)
Make the BeamSpectrumFile property in EQSANSNormalise a proper FileProperty
Reported by: | Russell Taylor | Owned by: | Russell Taylor |
---|---|---|---|
Priority: | minor | Milestone: | Release 3.2 |
Component: | SANS | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Mathieu Doucet |
Description
On 'new Jenkins', the system tests are run from a different directory, which is causing the EQSANSNormalisationAPIv2.EQSANSNormalisationInputFlux system test to fail. This turns out to be because the test is making assumptions about where it is being run from. This problem can be removed by making the BeamSpectrumFile property in EQSANSNormalise a FileProperty property instead of just a test one. Then it will find the file because its location is in the search path.
Change History
comment:2 Changed 7 years ago by Russell Taylor
- Status changed from assigned to inprogress
Re #9311. Make the BeamSpectrumFile property a FileProperty.
This obviates the need to give a full path if the file is in the search path.
Changeset: 805daa235b238cb15eb8b8404b0f5c96f0bc82f4
comment:3 Changed 7 years ago by Russell Taylor
Re #9311. Just give filename, not full path.
This works now that the BeamSpectrumFile property in EQSANSNormalise is a FileProperty instead of just a text one.
Changeset: 516f817b779367f6d7fc7e3c24f8c2497eccf167
comment:4 Changed 6 years ago by Russell Taylor
- Status changed from inprogress to verify
- Resolution set to fixed
To test: Note that all EQSANS system tests are passing. Check that the relevant functionality works via the ORNL SANS interface.
Note that there is a branch (called feature/9311_eqsansnormalise_fileproperty) in both the mantid and the systemtests repository for this.
comment:5 Changed 6 years ago by Mathieu Doucet
- Status changed from verify to verifying
- Tester set to Mathieu Doucet
comment:6 Changed 6 years ago by Mathieu Doucet
- Status changed from verifying to closed
Merge remote branch 'origin/feature/9311_eqsansnormalise_fileproperty'
Full changeset: a8c6d8aac3990aa549859932293109e202b3059a
comment:7 Changed 6 years ago by Russell Taylor
Merge remote branch 'origin/feature/9311_eqsansnormalise_fileproperty'
Full changeset: 8e95d48a345de6af34e8d3f010c49b8e3eb0296d