Ticket #9320 (closed: fixed)
Modify LoadRaw parameters to be compartible with LoadEventNexus when loading monitors
Reported by: | Alex Buts | Owned by: | Alex Buts |
---|---|---|---|
Priority: | major | Milestone: | Release 3.2 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Keith Brown |
Description
This would allow one to use generic Load command to load both raw data and event nexus data. Currently it does not work as LoadEventNexus accepts LoadMonitors ={true,false} and LoadRaw -- LoadMonitors={Include,Separate,Exclude}
Old interface should also work as before.
Change History
comment:2 Changed 6 years ago by Alex Buts
- Status changed from assigned to inprogress
refs #9320 LoadRaw accepts 0 and 1 as accepted options
Changeset: 436ce00892b80e40520d9da7caac00ab88855f52
comment:3 Changed 6 years ago by Alex Buts
refs #9320 Change LoadRaw custom dialog not to show "0" and "1"
as available options
Changeset: b9ec80af91db24d4929f7788f749fd24f4096795
comment:4 Changed 6 years ago by Alex Buts
refs #9320 Merge branch 'feature/9320_LoadRawOptions' into develop
Conflicts:
Code/Mantid/Framework/DataHandling/src/LoadRaw3.cpp
Changeset: 015ce4da6d68a7470e5c67cc749344d619271828
comment:5 Changed 6 years ago by Alex Buts
refs #9320 RHEL error: Remove std::end
as it seems not available on Ubuntu and OSX
Changeset: 3b5eacd1501f6101a84a589cf752cefbc24aa2ba
comment:6 Changed 6 years ago by Alex Buts
refs #9320 Rename GUI option Monitors to LoadMonitors
Because this is the key word which used in scripts. Having it as Monitors in GUI is confusing.
Changeset: a1174c47ac2a6c0a6651d9a57ca6ab2fa9cd2602
comment:8 Changed 6 years ago by Alex Buts
- Status changed from inprogress to verify
- Resolution set to fixed
The script
ws1=Load(Filename='MAR11001.RAW',LoadMonitors='1') ws2=Load(Filename='MAR11001.RAW',LoadMonitors='0')
fails before applying this ticket but runs after. The results of load show that "1" is equal to separate and "0" to exclude.
The same command will now load event nexus file if provided (e.g. LET00006278.nxs)
Tester can check that LoadRaw dialogue has not changed.
comment:9 Changed 6 years ago by Keith Brown
- Status changed from verify to verifying
- Tester set to Keith Brown
comment:10 Changed 6 years ago by Alex Buts
refs #9320 fixing merge conflicts with master accumulated
when this ticket went festering on test
Merge branch 'master' into feature/9320_LoadRawOptions
Conflicts:
Code/Mantid/Framework/DataHandling/src/LoadRaw3.cpp
Changeset: 321e3f5a8007e510c6e94b828f190b311a8bd88b
comment:11 Changed 6 years ago by Keith Brown
compared with current release, and checked code. Works as described
comment:12 Changed 6 years ago by Keith Brown
Merge remote-tracking branch 'origin/feature/9320_LoadRawOptions'
Conflicts:
Code/Mantid/Framework/DataHandling/src/LoadRaw3.cpp
Refs #9320
Changeset: 0a79175957edc2410ca4e5d5253bb867520fa0a6
comment:13 Changed 6 years ago by Keith Brown
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/9320_LoadRawOptions'
Conflicts:
Code/Mantid/Framework/DataHandling/src/LoadRaw3.cpp
Refs #9320
Full changeset: 0a79175957edc2410ca4e5d5253bb867520fa0a6
comment:14 Changed 6 years ago by Keith Brown
Merge remote-tracking branch 'origin/feature/9320_LoadRawOptions'
Full changeset: a5d79fe973fe18c42abbae7f8c67c31e7f447294
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10163