Ticket #9328 (closed: fixed)
libgomp missing from ninja builds
Reported by: | Peter Peterson | Owned by: | Peter Peterson |
---|---|---|---|
Priority: | major | Milestone: | Release 3.2 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Stuart Campbell |
Description
The easy test to see that this is fixed is to try
python -c "import mantid"
In master it gives a result of
Traceback (most recent call last): File "<string>", line 1, in <module> File "mantid/__init__.py", line 64, in <module> import kernel File "mantid/kernel/__init__.py", line 15, in <module> flags = _pydlopen.setup_dlopen(clib, ['libMantidKernel']) File "mantid/kernel/dlopen.py", line 98, in setup_dlopen dlloader(get_libpath(pythonlib, dep)) RuntimeError: /home/pf9/builds/mantid-ninja/bin/libMantidKernel.so: undefined symbol: GOMP_critical_name_end
This ticket is meant to make that go away.
Change History
comment:2 Changed 6 years ago by Peter Peterson
- Status changed from new to assigned
- Component changed from Framework to Diffraction
- Summary changed from libgomp missing for ninja builds to Remove CharacterizationsFile requirement from SNSPowderReduction
- type changed from enhancement to defect
- Milestone changed from Release 3.2 to Backlog
comment:4 Changed 6 years ago by Peter Peterson
- Status changed from assigned to verify
- Summary changed from Remove CharacterizationsFile requirement from SNSPowderReduction to libgomp missing from ninja builds
- Resolution set to fixed
- Milestone changed from Release 3.2 to Backlog
This is on feature/9328_ninja_gomp
To test: See that the builds are working, then try out a ninja build (fedora 20 works for me) and run the one line bash script in the ticket description.
comment:6 Changed 6 years ago by Stuart Campbell
- Status changed from verify to verifying
- Component changed from Diffraction to Framework
- Tester set to Stuart Campbell
comment:7 Changed 6 years ago by Stuart I. Campbell
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/9328_ninja_gomp'
Full changeset: 50aed684f59ab2c9044c95035d6f349105f1731c
comment:8 Changed 6 years ago by Wenduo Zhou
Merge remote-tracking branch 'origin/bugfix/9328_snspowder_no_char'
Full changeset: d7d1970b64758c760dcd6c43f572d113c4facf3a
Note: See
TracTickets for help on using
tickets.
Added gomp to the module linking flags.
Re #9328. It appears that make appends the compile flags when calling the linker and ninja does not.
Changeset: eb06e215bafb5396752bd7fdbca705a7e4fbd9ab