Ticket #9355 (closed: fixed)
CalibrateRectangularDetector can fail if it runs close to midnight!
| Reported by: | Russell Taylor | Owned by: | Wenduo Zhou |
|---|---|---|---|
| Priority: | trivial | Milestone: | Release 3.2 |
| Component: | Tools | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Alex Buts |
Description (last modified by Wenduo Zhou) (diff)
I saw some failures of PG3Calibration where it failed to find and load back the output file from CalibrateRectangularDetectors. This turns out to be because the creation date makes up part of the filename (calculated within the algorithm), but the line in the test that works out the date is after the (time-consuming) algorithm has run. So these can be different if the algorithm is running at midnight!!
The change here will be to move the computation of what the output filename will be to before the call to the algorithm. I suppose this is not guaranteed to be correct, but I believe the algorithm works it out close to the start so the odds are strongly that it will be.
The name of the calibration file is generated at the end of CalibrateRectangularDetectors. So no matter where to guess the calibration file name in the system test, there is always possibility to have the midnight issue.
The only safe solution is to make CalibrateRectangularDetectors to return the calibration file name.
Change History
comment:2 Changed 6 years ago by Russell Taylor
- Status changed from assigned to inprogress
Re #9355. Move computation of what output filename will be.
Putting it before the algorithm call gives us a better chance of getting it right if the algorithm runs over midnight.
Changeset: e6f6c5a6e7c9fc95e4484b557a82a17557db2174
comment:3 Changed 6 years ago by Russell Taylor
- Status changed from inprogress to verify
- Resolution set to fixed
Tester: The branch is here in the systemtests repository.
The test hasn't run near midnight recently. Probably just test by inspection.
comment:4 Changed 6 years ago by Wenduo Zhou
- Status changed from verify to verifying
- Tester set to Wenduo Zhou
comment:5 Changed 6 years ago by Wenduo Zhou
- Status changed from verifying to reopened
- Resolution fixed deleted
comment:8 Changed 6 years ago by Wenduo Zhou
- Status changed from reopened to inprogress
Use cal file name from CalibrateRectangularDetectors. Refs #9355.
Changeset: e313667aad299632067c91587e25142bf5f968c7
comment:9 Changed 6 years ago by Wenduo Zhou
- Status changed from inprogress to verify
- Resolution set to fixed
For tester
- Check whether system test CalibrateRectangularDetectors_Test is passed;
- Check whether the change in CalibrateRectangularDetectors is reasonable.
comment:10 Changed 6 years ago by Alex Buts
- Status changed from verify to verifying
- Tester changed from Wenduo Zhou to Alex Buts
comment:11 Changed 6 years ago by Alex Buts
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/9355_calibraterectangulardetectors_date'
Full changeset: ba72e6152b1cb0c4876ae295ec38cc80869ef0f9
comment:12 Changed 6 years ago by Alex Buts
Merge remote-tracking branch 'origin/bugfix/9355_calibraterectangulardetectors_date'
Full changeset: 600e5bd1bd41044136096c7b1eb73433c9b1ce5b
comment:13 Changed 6 years ago by Alex Buts
was indeed failed at midnight and not any more.
comment:14 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10198
