Ticket #9386 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

cppcheck warning fixes

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: trivial Milestone: Release 3.2
Component: Tools Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

There are a couple of cppcheck warnings in master that should be cleared. They are also the only two currently showing in the develop branch build.

One was let through from #9082 and the other (in SliceViewer.cpp) has apparently only just started being picked up even though the code has been there for many months.

Change History

comment:1 Changed 6 years ago by Russell Taylor

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Russell Taylor

  • Status changed from assigned to inprogress

Re #9386. Rethrow original exception, not a copy.

Changeset: da18c87261cd91913bb31a6c0a72f092ba30b335

comment:3 Changed 6 years ago by Russell Taylor

Re #9386. Pass string by reference instead of value.

Changeset: 28472aeb43b0d0e386ff464e96e9943050680a19

comment:4 Changed 6 years ago by Russell Taylor

  • Status changed from inprogress to verify
  • Resolution set to fixed

The ​cppcheck job (as well as the surrounding static analysis one) is blue! Hopefully it still will be when this gets tested.

comment:5 Changed 6 years ago by Russell Taylor

Re #9386. Remove now-unused parameter.

Changeset: caba73cc12aa08dea34af417b9fa956cda6b0b98

comment:6 Changed 6 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:7 Changed 6 years ago by Michael Reuter

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9386_cppcheck_warnings'

Full changeset: ​d79230e3e43ae7e79cc75f7ffe12c032f7234e48

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10229

Note: See TracTickets for help on using tickets.