Ticket #9399 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Add optional tableworkspace containing peak range to GetDetOffsetsMultiPeaks

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: major Milestone: Release 3.2
Component: Framework Keywords:
Cc: petersonpf@… Blocked By:
Blocking: Tester: Peter Peterson

Description

Add an optional input TableWorkspace to GetDetOffsetsMultiPeaks's properties. The TableWorkspace should contain the range of all peaks of all spectra for calibration.

GetDetOffsetsMultiPeaks then will parse the table workspace and pass the peak fitting range to FindPeaks.

Attachments

verify9399.py​ (3.5 KB) - added by Wenduo Zhou 6 years ago.

Change History

comment:1 Changed 6 years ago by Wenduo Zhou

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Wenduo Zhou

  • Status changed from assigned to inprogress

Refs #9399. Added a TableWorkspace to input fit windows.

also including a unit test for the new feature.

Changeset: 82dc63a84d566d141ebb79f18a2876ff70303e56

Changed 6 years ago by Wenduo Zhou

comment:3 Changed 6 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

For tester

  1. Download the attached python script, which will calibrate NOMAD with (new way) and without (old way) using Fit-Window-TableWorkspace;
  2. Build mantid and run script;
  3. Compare the 2d plots of the calibrated workspaces of 2 approaches;
  4. The new approach will mask more spectra, for example, 75949, 75956, 75863 and 95961. You will find that these spectra are too noisy to fit peaks. The old approach just does some false fitting.

comment:4 Changed 6 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:5 Changed 6 years ago by Pete Peterson

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9399_fitwindow_tablews'

Full changeset: ​3d366091d087051f83490227debb753fa52efd50

comment:6 Changed 6 years ago by Peter Peterson

I created #9459 to expose this in a way users can use.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10242

Note: See TracTickets for help on using tickets.