Ticket #9447 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Remove unused property in FindPeaks

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: major Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Jay Rainey

Description

In FindPeaks, a property named 'PeakHeightTolerance' is not well defined and not used in FindPeaks either. Delete it!

Change History

comment:1 Changed 6 years ago by Owen Arnold

  • Priority changed from minor to major
  • Status changed from new to assigned

Increased the importance of this since we do not want to prolong the life of properties that users may end up relying on. Be careful about removing this property if users have had access to it in previous mantid iterations.

comment:2 Changed 6 years ago by Wenduo Zhou

  • Status changed from assigned to inprogress

comment:3 Changed 6 years ago by Wenduo Zhou

Refs #9447. Removed unused property PeakHeightTolerance.

And the variables related to this property.

Changeset: 650021521b4c7115831fb490ea1489aa2b7a3f97

comment:4 Changed 6 years ago by Wenduo Zhou

For tester

The purpose of this ticket is to remove a property 'PeakHeightTolerance'. It is never used in any unit test and by other algorithms such as GetDetOffsetsMultiPeaks and StripPeaks. You can examine the source code to see that there is no affect on the behavior of FindPeaks with the change.

comment:5 Changed 6 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:6 Changed 6 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:7 Changed 6 years ago by Jay Rainey

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9447_findpeaks_rm_property'

Full changeset: ​91c54a7f448fdf8aa5c92195e51641f32fef7e5c

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10290

Note: See TracTickets for help on using tickets.