Ticket #9468 (closed: fixed)
MantidPlot missing TableWorkspace Sorting functionality
Reported by: | Owen Arnold | Owned by: | Roman Tolchenov |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.3 |
Component: | GUI | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Raquel Alvarez Banos |
Description (last modified by Nick Draper) (diff)
We have an embarrassing bug in Mantid we should fix prior to the next release.
1) Create a workspace as follows:
table = CreateEmptyTableWorkspace() table.addColumn('double', 'a') table.addColumn('str', 'b') table.addRow([1.0, "x"]) table.addRow([4.0, "y"]) table.addRow([2.0, "z"])
2) Open the table in MantidPlot
3) Right-click the table and go to 'Sort Table'. Try to sort the table either Ascending or Descending by column 'a'. Nothing Happens!
As a corollary to this, We ought to be able to sort the table workspace via an Algorithm. We can do this for PeaksWorkspaces via http://www.mantidproject.org/SortPeaksWorkspace. We ought to be able to do the same thing for a TableWorkspace.
Also undo the changes in #9796 which hides this functionality.
Change History
comment:1 Changed 6 years ago by Nick Draper
- Priority changed from blocker to critical
- Status changed from new to assigned
- Component changed from Framework to User Interface
comment:2 Changed 6 years ago by Nick Draper
- Description modified (diff)
- Milestone changed from Release 3.2 to Release 3.3
dropped from this release, but #9796 left in it's place
comment:3 Changed 6 years ago by Roman Tolchenov
- Status changed from assigned to inprogress
Re #9468. Added SortTableWorkspace algorithm.
Changeset: 7d61d7f843a9e7fd2013fed5e05a20179879c973
comment:4 Changed 6 years ago by Roman Tolchenov
Re #9468. Added Ascending property
Changeset: 2cd7c57c27128efc7ee373828ca73b86c243a95f
comment:5 Changed 6 years ago by Roman Tolchenov
Re #9468. Added sorting methods to TableColumn class.
Changeset: ad3ab433ae7ee059ba5e6cd9fdd75ad6f9749be1
comment:6 Changed 6 years ago by Roman Tolchenov
Re #9468. Unit tests.
Changeset: 1393fecb65abc1a38f9672a88454e597f57a2931
comment:7 Changed 6 years ago by Roman Tolchenov
Re #9468. Specify order when sorting indices.
Changeset: 4ef0d6e49731cf7524de61e59104868e34c6a2ad
comment:8 Changed 6 years ago by Roman Tolchenov
Re #9468. Implemented sort() method of TableWorkspace.
Changeset: 738fe5d4da7fb54d56fa5dd4c757672b81eb261f
comment:9 Changed 6 years ago by Roman Tolchenov
Re #9468. Unit tests for SortTableWorkspace.
Changeset: 835239e49747dcb46581bd98b38570afc69f559f
comment:10 Changed 6 years ago by Roman Tolchenov
Re #9468. Wiki documentation. A unit test.
Changeset: 79c1800593a9c685c166de3e0ad5c23c62dc6ba3
comment:11 Changed 6 years ago by Roman Tolchenov
Re #9468. Added missing include.
Changeset: 1e3fcc76b8caf4eb9a23bde4c3310ca1fc3c0ee0
comment:12 Changed 6 years ago by Roman Tolchenov
Re #9468. Moved struct definition to an anonymous namespace.
Changeset: ea54a507c610327d2404d9346ca59a68b4e8027c
comment:13 Changed 6 years ago by Martyn Gigg
There's a broken system test as General is not an allowed category: http://builds.mantidproject.org/job/develop_systemtests_rhel6/lastCompletedBuild/testReport/SystemTests/SphinxWarnings/SphinxWarnings/
comment:14 Changed 6 years ago by Roman Tolchenov
Re #9468. Changed category to Utility.
Changeset: f10555e0b84025beb05f9451646a4fca32af26a8
comment:15 Changed 6 years ago by Roman Tolchenov
Re #9468. Custom algorithm dialog.
Changeset: d81647a5c5a0548f9e2e2fa327f9e4bbfed327e8
comment:16 Changed 6 years ago by Roman Tolchenov
Re #9468. Connected sort dialog to main menu.
Changeset: 131026f1b5fc9dc23b7b25a766abab9b163dc0d4
comment:17 Changed 6 years ago by Roman Tolchenov
Re #9468. Fix warning.
Changeset: 24d000631f8f3a2e0695668c45e1d16d0fe17c65
comment:18 Changed 6 years ago by Roman Tolchenov
- Status changed from inprogress to verify
- Resolution set to fixed
To test
- Create a table workspace, fill it with some data.
- Sort it by running SortTableWorkspace algorithm and by selecting Sort Table option from Table menu.
comment:19 Changed 6 years ago by Raquel Alvarez Banos
- Status changed from verify to verifying
- Tester set to Raquel Alvarez Banos
comment:20 Changed 6 years ago by Raquel Alvarez Banos
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/9468_sort_table'
Full changeset: 6ac83f5cb11a374ddb88572fa158a69479308305
comment:21 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10311
I agree with critical, but not blocker