Ticket #9491 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Y axis label for asymmetry plot

Reported by: Anders Markvardsen Owned by: Arturs Bekasovs
Priority: critical Milestone: Release 3.2
Component: Muon Keywords:
Cc: adrian.hillier@… Blocked By:
Blocking: Tester: Karl Palmen

Description

  1. Open MuonAnalysis interface
  1. Browse and plot AutoTestData\MUSR00015189.nxs

This produces Asymmetry plot.

Change Y axis label for asymmetry plot to be 'Asymmetry'

Set this as critical since this is a common plot produced by muon users

Change History

comment:1 Changed 6 years ago by Arturs Bekasovs

It seems that the YUnitLabel() is set correctly, but YUnit() is not:

ws.YUnit()
Out[11]: 'Counts'

ws.YUnitLabel()
Out[12]: 'Asymmetry'

MatrixWorkspace's methods use YUnitLabel(), which is why the units seem right in ADS view, but the plotting routines use the YUnit().

So we should set both correctly.

That's where it's done in AsymmetryCalc algorithm:

165: // Update Y axis label 
166: outputWS->setYUnitLabel("Asymmetry");
Last edited 6 years ago by Arturs Bekasovs (previous) (diff)

comment:2 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Arturs Bekasovs

  • Owner changed from Anders Markvardsen to Arturs Bekasovs

comment:4 Changed 6 years ago by Arturs Bekasovs

After speaking to Martyn and looking at the code, it turns out it should be enough to set YUnit only - it is used as a label if label is not set, and those two would be equal for that case anyway.

comment:5 Changed 6 years ago by Arturs Bekasovs

  • Status changed from assigned to inprogress

Refs #9491. Set the YUnit instead of YUnitLabel

Changeset: 74827eb89cccaf1ffedcdd8aaac75a18efe7a3fe

comment:6 Changed 6 years ago by Arturs Bekasovs

Refs #9491. Set actual units instead of label for group asym. as well

Changeset: 4b944b156bc18a901beed181a4ec7f12bc3a0f74

comment:7 Changed 6 years ago by Arturs Bekasovs

Tester:

Check that the problem was fixed.

Check that Y units are now set correctly for all kinds of plots:

  • Pair asymmetry
  • Group asymmetry
  • Group counts
  • Group counts on logarithmic scale

Check that units are displayed correctly in both plots and ADS view.

Verify that system tests are passing, and when closing the ticket please merge the branch in system tests repository as well.

Last edited 6 years ago by Arturs Bekasovs (previous) (diff)

comment:8 Changed 6 years ago by Arturs Bekasovs

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:9 Changed 6 years ago by Arturs Bekasovs

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:10 Changed 6 years ago by Arturs Bekasovs

  • Status changed from reopened to inprogress

Refs #9491. Update Y units for Muon reference results

Changeset: cc9798c566f5a20dc6322319383f346425889618

comment:11 Changed 6 years ago by Arturs Bekasovs

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:12 Changed 6 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:13 Changed 6 years ago by Karl Palmen

The plot from the Muon Analysis dialog box and those workspaces with Asym in name have Asymmetry as the Y axis name.

comment:14 Changed 6 years ago by Karl Palmen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9491_muon_y_axis_label_asymmetry'

Full changeset: 55d033f3fd3d536a8bcced1e3bef8a36f842bcc7

comment:15 Changed 6 years ago by Karl Palmen

Merge remote-tracking branch 'origin/bugfix/9491_muon_y_axis_label_asymmetry'

Full changeset: 2bb4b461d33ceb85f90958609f481932d371f845

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10334

Note: See TracTickets for help on using tickets.