Ticket #9494 (closed: fixed)
Workspace not named/grouped properly after fitting
Reported by: | Arturs Bekasovs | Owned by: | Arturs Bekasovs |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.2 |
Component: | Muon | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Anders Markvardsen |
Description
To reproduce:
- In MuonAnalysis, load a workspace, e.g MUSR15189.
- Plot something.
- Do any kind of fitting on the new plot.
- Try to plot something else. The new plots have incorrect names and are not grouped properly.
This happens because when grouping fitted workspaces in MuonAnalysisFitDataTab::groupFittedWorkspaces() we overwrite the workspace group which MuonAnalysis holds a pointer to for grouping and naming.
Change History
comment:2 Changed 6 years ago by Arturs Bekasovs
Refs #9494. Make the grouping function add to group if it exists
It makes it potentially faster and we can check for duplicates to avoid endless warnings.
Changeset: f314dbdd4b2436b220307fba28ddd406fc6cb18f
comment:4 Changed 6 years ago by Arturs Bekasovs
- Status changed from assigned to inprogress
Refs #9494. Set the correct include path
Forgot to fix that when rebased the ticket onto the master
Changeset: 1d2bd53d51c3e87a1120a97141a2d3a15bf27a6b
comment:5 Changed 6 years ago by Arturs Bekasovs
Tester:
Check that the problem was fixed.
And in general - load a few data sets, produce various types of plots, fit them, making sure everything ends up in the correct group and is named properly. Try to brake it!
comment:6 Changed 6 years ago by Arturs Bekasovs
- Status changed from inprogress to verify
- Resolution set to fixed
comment:7 Changed 6 years ago by Anders Markvardsen
- Status changed from verify to verifying
- Tester set to Anders Markvardsen
comment:8 Changed 6 years ago by Anders Markvardsen
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/9494_muon_empty_group_name_after_fitting'
Full changeset: 6ed110a37eaec94f276c0579d7fecb0e8102627e
Refs #9494. Store the current label instead of a pointer to ws group
The label gets updated when new data is loaded and is used for workspace naming and grouping. This seems to be more robust than storing a shared pointer and fixed the problem.
Changeset: a8b2aea6ac369c224ae17719c89fa1bdf12166c0