Ticket #9506 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Don't clear baseline model/peaks when changing data

Reported by: Arturs Bekasovs Owned by: Raquel Alvarez Banos
Priority: major Milestone: Backlog
Component: Muon Keywords: ALC
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description

As per Jamie, it might be very useful to keep the previous fittings for two reasons:

  1. Seeing the previous fitted baseline / peaks to see how they evolve with e.g. temperature falling.
  1. Previous values are usually good initial guesses for the next fit.

One case to consider though, is when the data is changed completely, e.g. when log is changed. I've seen a few cases when this makes the plot look ridiculous, because old fitted curve and new data had very distant X values. So should either make it rather easy to clear the old data, or make the plot to use the X values of the data only.

Change History

comment:1 Changed 6 years ago by Arturs Bekasovs

  • Milestone changed from Backlog to Release 3.2

Need to try to fit into the release - shouldn't be too difficult to do.

comment:2 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Nick Draper

  • Milestone changed from Release 3.2 to Backlog

Moved to Backlog at the code freeze of release 3.2

comment:4 Changed 6 years ago by Anders Markvardsen

  • Owner changed from Arturs Bekasovs to Anders Markvardsen

comment:5 Changed 6 years ago by Anders Markvardsen

  • Owner changed from Anders Markvardsen to Karl Palmen

comment:6 Changed 6 years ago by Anders Markvardsen

  • Owner changed from Karl Palmen to Raquel Alvarez Banos

comment:7 Changed 5 years ago by Raquel Alvarez Banos

  • Status changed from assigned to inprogress

Re #9506 Don't clear basline/corrected data/peaks

Changeset: b6eaf3087347001d616a4da39bde1922ad4b21a7

comment:8 Changed 5 years ago by Raquel Alvarez Banos

Re #9506 Don't clear sections when changing data

Changeset: 0a12546e6b26bb2418213484c422a1f9cdb99c23

comment:9 Changed 5 years ago by Raquel Alvarez Banos

Re #9506 Update unit test

Changeset: 2eb57a54e236e2d8f42da7e0782d63e102c52870

comment:10 Changed 5 years ago by Raquel Alvarez

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #586.

comment:11 Changed 5 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:12 Changed 5 years ago by Raquel Alvarez Banos

I am not considering the case of very different data (mentioned in the description) as when I spoke to scientists a couple of days ago they did not seem to be very concerned about it, and besides, the user can easily update fitting results just by hitting the "Fit" button. I will create a new ticket for this in the future if required/needed.

comment:13 Changed 5 years ago by Raquel Alvarez Banos

Re #9506 Don't clear basline/corrected data/peaks

Changeset: b6eaf3087347001d616a4da39bde1922ad4b21a7

comment:14 Changed 5 years ago by Raquel Alvarez Banos

Re #9506 Don't clear sections when changing data

Changeset: 0a12546e6b26bb2418213484c422a1f9cdb99c23

comment:15 Changed 5 years ago by Raquel Alvarez Banos

Re #9506 Update unit test

Changeset: 2eb57a54e236e2d8f42da7e0782d63e102c52870

comment:16 Changed 5 years ago by Karl Palmen

  • Status changed from verifying to closed

Merge pull request #586 from mantidproject/9506_Dont_clear_results_when_changing_data

Don't clear results when changing data

Full changeset: 85059abaf7cb01259aa2ae4dde2d8090cc15550c

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10349

Note: See TracTickets for help on using tickets.