Ticket #9517 (closed: fixed)
Algorithm history is not captured in binary operations
Reported by: | Samuel Jackson | Owned by: | Samuel Jackson |
---|---|---|---|
Priority: | major | Milestone: | Release 3.2 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Nick Draper |
Description
Performing a binary operation using the operator overrides on a workspace in a workflow algorithm doesn't get captured in the history. This leads to incomplete history records. We should investigate ways to fix this.
Change History
comment:2 Changed 6 years ago by Samuel Jackson
- Status changed from assigned to inprogress
Refs #9517 Add binary operation helper functions to DPA.
Changeset: 4f0e7cc5b9a1b6a301e887a389ad7169f8c1b459
comment:3 Changed 6 years ago by Samuel Jackson
Refs #9517 Fix divide calls in DPA algorithms.
Changeset: da13fea9225e865f62ee712c34cf990c5366422f
comment:4 Changed 6 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
I've added operator methods to Data Processor Algorithm. This provides an easy way to run binary operations without breaking history, as unfortunately there doesn't seem to be any way to keep the existing operator syntax.
To Test
- Check unit/system tests
- Code Review
- This modifies several work flow algorithms, so I suggest running the following and checking we get accurate history:
- CreateTransmissionWorkspace
- DgsReduction
- ReflectometryReductionOne
- SNSPowderReduction
comment:5 Changed 6 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:6 Changed 6 years ago by Nick Draper
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/9517_workspace_binary_ops'
Full changeset: 595bf7ac4e0dc6272703659f03522b48202bc844