Ticket #9554 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Checkbox for dead time correction

Reported by: Arturs Bekasovs Owned by: Raquel Alvarez Banos
Priority: critical Milestone: Release 3.4
Component: Muon Keywords: ALC
Cc: Blocked By:
Blocking: #9489 Tester: Federico M Pouzols

Description

This will be properly implemented in #9489, but to make the interface a bit more usable for the release, we should at least make it possible to correct using dead times stored in the Nexus files. This is just a matter of adding a check-box and passings its state to the PlotAsymmetryByLogValue.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Nick Draper

  • Owner changed from Arturs Bekasovs to Anders Markvardsen

comment:3 Changed 6 years ago by Anders Markvardsen

  • Milestone changed from Release 3.2 to Release 3.3

comment:4 Changed 6 years ago by Anders Markvardsen

  • Owner changed from Anders Markvardsen to Karl Palmen

comment:5 Changed 6 years ago by Nick Draper

  • Milestone changed from Release 3.3 to Release 3.4

Moved to R3.4

comment:6 Changed 6 years ago by Anders Markvardsen

  • Owner changed from Karl Palmen to Raquel Alvarez Banos

comment:7 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from assigned to inprogress

Re #9554 updating interface widgets for dead time corrections

Changeset: 880c144bb6cbd70a063ea5c47e749e55e10f6565

comment:8 Changed 6 years ago by Raquel Alvarez Banos

Re #9554 Deadtime file only enabled if FromCustomFile selected

Changeset: 3b4c648cc88a38343ccdc83d6f7bcd4c04d68901

comment:9 Changed 6 years ago by Raquel Alvarez Banos

Re #9554 Change default dead time correction type

Changeset: 14fd34f4c943f37c42e4da1a7e3d47af3e249e44

comment:10 Changed 6 years ago by Raquel Alvarez Banos

Re #9554 Connect ALC interface with PlotAsymmetryLogValue algorithm

Changeset: 5929e96618e0ccd456207c64da65861225f72a3a

comment:11 Changed 6 years ago by Raquel Alvarez Banos

Re #9554 adding unit test

Changeset: 1450ba04f911675b51a2a5a1653e468c1e54160c

comment:12 Changed 6 years ago by Raquel

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #318.

comment:13 Changed 6 years ago by Raquel

Jenkins, retest this please

comment:14 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:15 Changed 6 years ago by Federico M Pouzols

All looks fine and the new code comes with a couple of new test cases. The interface seems to behave well with example data.

Double checking the GUI mockups I noticed that the help (?) buttons are missing from the interface (in the 3 steps). If you add them, the buttons could just open http://www.mantidproject.org/Muon_ALC. Oh, I was just told that this is already considered as part of ticket #9495: http://trac.mantidproject.org/mantid/ticket/9495.

comment:16 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to closed

Merge pull request #318 from mantidproject/9554_Checkbox_for_deadtime_corrections

Allow deadtime corrections in Muon ALC

Full changeset: 8b7efb3e239af0bb04d200db4cc1e6f389e84232

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10397

Note: See TracTickets for help on using tickets.