Ticket #9563 (closed: fixed)
Add code to parse remainder of Beam Monitor Packets
Reported by: | Ross Miller | Owned by: | Ross Miller |
---|---|---|---|
Priority: | major | Milestone: | Release 3.2 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #9542 | Tester: | Russell Taylor |
Description
In the SNS Live Listener, we can partially parse the beam monitor packets, but there's a bunch of information that we ignore. Add code to parse this data.
Change History
comment:2 Changed 6 years ago by Ross Miller
Update handling of beam monitor packets
Fix 2 problems with how beam monitor packets are parsed: 1) Properly deal with the case where a packet has no actual events 2) When checking to see if we'd reached the end of the packet, the code was including the size of the packet header when it shouldn't have.
Refs #9563
Changeset: 184e8fa58dcee26810cc1d7d19cf5009481c333e
comment:4 Changed 6 years ago by Ross Miller
- Status changed from assigned to inprogress
Get event data from beam monitor packets
Added functions to retrieve event TofF and other data from the beam monitor packets. Removed the firstSection() function because it wasn't really needed.
Also, some indendation cleanup (tabs vs. spaces)
Refs #9563
Changeset: 094f713b582689106312ffb3c67c186ffb3fe344
comment:5 Changed 6 years ago by Ross Miller
Fix Windows compile warning
The MS compiler didn't like me casting the results of a bitwise AND to a bool.
Refs #9563
Changeset: 35c19ac92e033a9ef25fb310492d25ceefe31620
comment:6 Changed 6 years ago by Ross Miller
- Status changed from inprogress to verify
- Resolution set to fixed
comment:7 Changed 6 years ago by Ross Miller
- Status changed from verify to reopened
- Resolution fixed deleted
comment:8 Changed 6 years ago by Ross Miller
- Status changed from reopened to inprogress
Fix Monitor ID bitmask
The bitmask used to separate the MonitorID field from everything else in the BeamMonitor packets was off by one bit. Since the MonitorID field is actually the top 10 bits the mask wasn't even needed (just a right shift operation).
Refs #9563
Changeset: b1bedd247643d8758ac572d846ab81f649cffe74
comment:9 Changed 6 years ago by Ross Miller
- Status changed from inprogress to verify
- Resolution set to fixed
comment:10 Changed 6 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:11 Changed 6 years ago by Russell Taylor
- Status changed from verifying to closed
Merge remote branch 'origin/feature/9563_beam_monitor_packets'
Full changeset: ffd1aea2bcc9d1b347931fce2d6aff16bae968eb
comment:12 Changed 6 years ago by Russell Taylor
I now see the monitor IDs that I expect to see. My initial code for #9542 is able to read monitor events that match those that wind up in the nexus file.
comment:13 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10406
Fix bad beam monitor ID error message
Apparently, the Mantid logger won't print error messages unless they end with a newline char. Had to add one to the bad beam monitor ID error.
Refs #9563
Changeset: a6049fa64b940312472481701e5b6ac38767f74d