Ticket #957 (closed: invalid)

Opened 11 years ago

Last modified 5 years ago

Further work on peak finding and stripping

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: major Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Peterson

Description (last modified by Russell Taylor) (diff)

FindPeaks still is not always successful in finding peaks. Possible improvements:

  • It still has an underlying assumption that the bins/data points are equally spaced.
  • The way it incorporates a loop calling the fitting function (currently Gaussian) seems unnecessary - we should pass in the initial width guess from the finding algorithm instead.
  • Add an option to use a different function in the fit part (or none at all)
  • StripPeaks needs to take account of the fitting function used - at the moment it just hard-codes a Gaussian
  • Could look at FullProf peak finding as well

Change History

comment:1 Changed 10 years ago by Peter Peterson

  • Description modified (diff)

comment:2 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:3 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:4 Changed 10 years ago by Nick Draper

  • Owner changed from Russell Taylor to Roman Tolchenov
  • Status changed from new to assigned
  • Component set to Mantid
  • Milestone changed from Iteration 28 to Iteration 30

comment:5 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:6 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:7 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:8 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:9 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:10 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:11 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:12 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:13 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:14 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:15 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move to assigned at the introduction of the triage step

comment:16 Changed 7 years ago by Russell Taylor

  • Status changed from assigned to verify
  • Owner changed from Roman Tolchenov to Russell Taylor
  • Resolution set to invalid
  • Description modified (diff)

I'm going to argue that this ticket is no longer relevant - FindPeaks is utterly transformed compared to when this was written. Anyone on the cc list can grab it and reopen if they disagree.

comment:17 Changed 7 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:18 Changed 7 years ago by Peter Peterson

  • Status changed from verifying to closed
  • Milestone changed from Backlog to Release 3.2

I completely agree with Russell.

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​1805

Note: See TracTickets for help on using tickets.