Ticket #9616 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Stop Reduction Completely If Calibration/Efficiency Files are Missing

Reported by: Peter Parker Owned by: Jay Rainey
Priority: critical Milestone: Release 3.2
Component: SANS Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Parker

Description

Currently, only warnings are outputted if a reduction starts with a User File pointing to calibration or efficiency files that are missing.

Instead, we need the reduction to stop and an error to be presented to the user.

Note that I have already done something similar to what is required, only with missing mask files (see ticket #9481).

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Jay Rainey

  • Status changed from assigned to inprogress

Throw error if no calibration file exists. Refs #9616.

Changeset: e5be71040d402bc84f565a9bf74a93b1b48a4d51

comment:3 Changed 6 years ago by Jay Rainey

Update mask error message to be consistent. Refs #9616.

Changeset: ab087ef71ba51e61d0ea5956854bfe8ee45a0a81

comment:4 Changed 6 years ago by Jay Rainey

Check before trying to load MON file. Refs #9616.

Changeset: bff5556abe183afb1aa4ed8544ae542a2cfe2f0e

comment:5 Changed 6 years ago by Jay Rainey

Fix build servers by disabling MON check. Refs #9616.

Changeset: dfe34c48956506a1f5a46baa44d2e03047c1339c

comment:6 Changed 6 years ago by Jay Rainey

Add check before execution. Refs #9616.

Changeset: 46d74159e9ef412aeeb7f897d8387e8deea2e748

comment:7 Changed 6 years ago by Jay Rainey

Add empty file required set in MASK. Refs #9616.

Changeset: d8d7e052a3ca713881fe5f7f9c2d16a13d599162

comment:8 Changed 6 years ago by Jay Rainey

  • Status changed from inprogress to verify
  • Resolution set to fixed

This ticket prevents the reduction from carrying on should an error occur, specifically ones related to files that have been declared in the MASK file, but don't exist.

comment:9 Changed 6 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

comment:10 Changed 6 years ago by Nick Draper

  • Status changed from verifying to verify
  • Tester Peter Parker deleted

comment:11 Changed 6 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:12 Changed 6 years ago by Nick Draper

  • Status changed from verifying to verify
  • Tester Nick Draper deleted

comment:13 Changed 6 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

comment:14 Changed 6 years ago by Peter Parker

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9616_stop_reduction_on_error'

Full changeset: ​c418865dfbc96ada28abd534f1221035ed1041a8

comment:15 Changed 6 years ago by Peter Parker

Seems fine.

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10459

Note: See TracTickets for help on using tickets.